aes: Split FFI helpers into their own submodule. #2102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2102 +/- ##
==========================================
+ Coverage 97.24% 97.25% +0.01%
==========================================
Files 143 144 +1
Lines 20144 20148 +4
Branches 228 228
==========================================
+ Hits 19589 19595 +6
- Misses 527 528 +1
+ Partials 28 25 -3 ☔ View full report in Codecov by Sentry. |
briansmith
commented
Jun 14, 2024
| debug_assert_ne!(key.rounds, 0); // Sanity check initialization. | ||
| Ok(key) | ||
| } else { | ||
| Err(error::Unspecified) |
There was a problem hiding this comment.
It is expected that this isn't reached because we've met all the preconditions to ensure the function won't fail.
| }, | ||
| }; | ||
| }?; |
There was a problem hiding this comment.
This isn't reachable because the branch where the called function returns an error isn't reachable. No different tha before. We'll deal with this in a future change.
Make it clearer which types are used in the FFI and start separating the (unsafe) code for dealing with the C/assembly implementations from the (mostly safe) rest of the code. `git difftool HEAD^1:src/aead/aes.rs src/aead/aes/ffi.rs`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it clearer which types are used in the FFI and start separating the (unsafe) code for dealing with the C/assembly implementations from the (mostly safe) rest of the code.
git difftool HEAD^1:src/aead/aes.rs src/aead/aes/ffi.rs.