cpu: Make cpu::Features be !Send.
#2101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2101 +/- ##
=======================================
Coverage 97.24% 97.25%
=======================================
Files 143 143
Lines 20144 20144
Branches 228 228
=======================================
+ Hits 19589 19591 +2
Misses 527 527
+ Partials 28 26 -2 ☔ View full report in Codecov by Sentry. |
briansmith
force-pushed
the
b/features-not-send
branch
from
cf73746
to
8226391
Compare
We don't intend to put `cpu::Features` in any type that could be sent across threads. Enforce this in the type system. This way, we can potentially change the representation of `cpu::Features` to one that really couldn't be `Send` in the future.
briansmith
force-pushed
the
b/features-not-send
branch
from
8226391
to
d070e13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't intend to put
cpu::Featuresin any type that could be sent across threads. Enforce this in the type system. This way, we can potentially change the representation ofcpu::Featuresto one that really couldn't beSendin the future.