-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed toolchain to stable for coverage #1987
base: main
Are you sure you want to change the base?
Conversation
changed nightly to stable tool chain in ci.yml for coverage.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1987 +/- ##
==========================================
+ Coverage 96.32% 96.80% +0.48%
==========================================
Files 137 143 +6
Lines 20704 20434 -270
Branches 226 226
==========================================
- Hits 19943 19782 -161
+ Misses 728 618 -110
- Partials 33 34 +1 ☔ View full report in Codecov by Sentry. |
From the CI run:
This kind of crash seems to happen when the clang version doesn't match the LLVM version that Rust uses. It seems like we upgraded clang in CI to what Nightly Rust uses. In order to move forward with this change, we may either need to downgrade to the earlier version of clang that matches stable Rust's LLVM version, or wait until the next stable Rust is released. You might try using channel |
@briansmith You are right |
checking beta channel for LLVM compatibility.
@Raghav-Bell Do you want to try again now? |
OK, this seems to be working now on stable. Could you please do the following?:
|
Since PR #2056 was merged, we'll need to wait for Rust 1.80 (IIUC) to become stable, or else add a wokaround that forces the use of nightly for the armv7 target. |
It fixes #1902