Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for LoongArch64 #1632

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Add support for LoongArch64 #1632

merged 1 commit into from
Oct 2, 2023

Conversation

heiher
Copy link
Contributor

@heiher heiher commented Sep 3, 2023

Follow up #1565

@heiher heiher mentioned this pull request Sep 3, 2023
@heiher heiher changed the title Add loongarch64 support in base.h & mk Add support for LoongArch64 Sep 8, 2023
Copy link
Owner

@briansmith briansmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heiher The stuff in base.h is now to be in target.h. Note that the clippy job failed; try mk/clippy.sh. Please rebase on the main branch and resubmit.

@heiher heiher requested a review from briansmith October 1, 2023 02:43
@briansmith
Copy link
Owner

Is there no QEMU support for this target? Could you please add the rest of the stuff like the other targets have for QEMU to cargo.sh and install-build-tools.sh? This makes it very easy for us to all test this target manually, even if we don't add it to CI.

@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

Merging #1632 (78a453f) into main (901441f) will decrease coverage by 0.01%.
Report is 5 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1632      +/-   ##
==========================================
- Coverage   96.04%   96.03%   -0.01%     
==========================================
  Files         133      133              
  Lines       19913    19913              
  Branches      199      199              
==========================================
- Hits        19125    19124       -1     
  Misses        752      752              
- Partials       36       37       +1     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@briansmith briansmith merged commit 3d592b2 into briansmith:main Oct 2, 2023
150 of 151 checks passed
@briansmith
Copy link
Owner

I couldn't find the toolchain support in Ubuntu 22.04. Please help Ubuntu get your cross-compilation and QEMU support into Ubuntu if you haven't already. Thanks!

@heiher
Copy link
Contributor Author

heiher commented Oct 2, 2023

I couldn't find the toolchain support in Ubuntu 22.04. Please help Ubuntu get your cross-compilation and QEMU support into Ubuntu if you haven't already. Thanks!

You're right. Fortunately, Debian/LoongArch port is already in progress. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants