-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for LoongArch64 #1632
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@heiher The stuff in base.h
is now to be in target.h
. Note that the clippy
job failed; try mk/clippy.sh
. Please rebase on the main branch and resubmit.
Is there no QEMU support for this target? Could you please add the rest of the stuff like the other targets have for QEMU to cargo.sh and install-build-tools.sh? This makes it very easy for us to all test this target manually, even if we don't add it to CI. |
Codecov Report
@@ Coverage Diff @@
## main #1632 +/- ##
==========================================
- Coverage 96.04% 96.03% -0.01%
==========================================
Files 133 133
Lines 19913 19913
Branches 199 199
==========================================
- Hits 19125 19124 -1
Misses 752 752
- Partials 36 37 +1 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I couldn't find the toolchain support in Ubuntu 22.04. Please help Ubuntu get your cross-compilation and QEMU support into Ubuntu if you haven't already. Thanks! |
You're right. Fortunately, Debian/LoongArch port is already in progress. Thanks! |
Follow up #1565