-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install: fix absolute symbolic permissions #841
Open
mknos
wants to merge
1
commit into
briandfoy:master
Choose a base branch
from
mknos:install-msym
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When using '=' with 'install -m", the resulting file permissions weren't right; here's what I found... * mod() should be passed the original file to stat(), but it was being passed the target file after File::Copy::copy() created it * Base permissions for "absolute" symbolic permissions (i.e. those set with '=') are zero, so it is not correct to stat() the original file in this case * The statement clearing bits in perms-hash for operator '=' in loop should only clear bits for $who the current iteration looks at %perl install -m u=rwx,g=rx,o=x comm a/comm # -m 751 %perl install -m u=rwx,g=r comm a/comm # -m 740 %perl perl install -m 'a=' comm a/comm # -m 0
github-actions
bot
added
Type: enhancement
improve a feature that already exists
Priority: low
get to this whenever
Program: install
The install program
labels
Nov 27, 2024
mknos
temporarily deployed
to
automated_testing
November 27, 2024 01:14
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 27, 2024 01:14
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 27, 2024 01:14
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 27, 2024 01:14
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 27, 2024 01:14
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 27, 2024 01:14
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 27, 2024 01:14
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 27, 2024 01:14
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 27, 2024 01:14
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 27, 2024 01:14
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 27, 2024 01:14
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 27, 2024 01:14
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 27, 2024 01:14
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 27, 2024 01:14
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 27, 2024 01:14
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 27, 2024 01:14
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 27, 2024 01:14
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 27, 2024 01:14
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 27, 2024 01:14
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 27, 2024 01:15
— with
GitHub Actions
Inactive
Pull Request Test Coverage Report for Build 12041873260Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Priority: low
get to this whenever
Program: install
The install program
Type: enhancement
improve a feature that already exists
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
%perms
for operator '=' in loop should only clear bits for $who the current iteration looks at