Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expr: allow '--' prefix #840

Merged
merged 1 commit into from
Nov 26, 2024
Merged

expr: allow '--' prefix #840

merged 1 commit into from
Nov 26, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 26, 2024

  • Compat change; GNU and OpenBSD versions do this
  • If the first argument is '--' and it's not the only argument, ignore it
  • test1: perl expr -- # invalid
  • test2: perl expr -- -- # evaluates string "--"
  • test3: perl expr -- 2 - 2 # evaluates number 0

@mknos
expr: allow '--' prefix
1690e57 
* Compat change; GNU and OpenBSD versions do this
* If the first argument is '--' and it's not the only argument, ignore it
* test1: perl expr -- # invalid
* test2: perl expr -- -- # evaluates string "--"
* test3: perl expr -- 2 - 2 # evaluates number 0
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: expr The expr program labels Nov 26, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12023978314

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 12016871827: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@coveralls
Copy link

coveralls commented Nov 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12023978309

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 12016871827: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy merged commit 1aaf645 into briandfoy:master Nov 26, 2024
22 of 23 checks passed
@briandfoy
Copy link
Owner

changes: ignore -- if it's the first argument (fatal is it is the only argument)

@briandfoy briandfoy self-assigned this Nov 26, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: expr The expr program Status: accepted The fix is accepted Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy