Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chown: allow numeric group argument #822

Merged
merged 1 commit into from
Nov 19, 2024
Merged

chown: allow numeric group argument #822

merged 1 commit into from
Nov 19, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 18, 2024

  • Previously the usage "chown USER file" was changed to allow numeric user ID for USER
  • When testing against GNU version, the usage "chown USER:GROUP file" should handle a group ID or a group name
  • test1: perl chown 0:0 file ---> user=root, group=root on my Linux system
  • test2: perl chown root:8 ---> also valid, where gid 8 resolves to "mail" here

@mknos
chown: allow numeric group argument
aeec674 
* Previously the usage "chown USER file" was changed to allow numeric user ID for USER
* When testing against GNU version, the usage "chown USER:GROUP file" should handle a group ID or a group name
* test1: perl chown 0:0 file ---> user=root, group=root on my Linux system
* test2: perl chown root:8 ---> also valid, where gid 8 resolves to "mail" here
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: chown The chown program labels Nov 18, 2024
@mknos mknos temporarily deployed to automated_testing November 18, 2024 23:18 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 18, 2024 23:18 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 18, 2024 23:18 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 18, 2024 23:18 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 18, 2024 23:18 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 18, 2024 23:18 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 18, 2024 23:18 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 18, 2024 23:18 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 18, 2024 23:18 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 18, 2024 23:18 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 18, 2024 23:18 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 18, 2024 23:18 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 18, 2024 23:18 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 18, 2024 23:18 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 18, 2024 23:18 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 18, 2024 23:18 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 18, 2024 23:18 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 18, 2024 23:18 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 18, 2024 23:18 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 18, 2024 23:18 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Nov 18, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11902905057

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.069%
Totals Coverage Status
Change from base Build 11888199200: 0.0%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy merged commit 547845d into briandfoy:master Nov 19, 2024
23 checks passed
@briandfoy
Copy link
Owner

changes: allow for numeric group in user:group notation

@briandfoy briandfoy self-assigned this Nov 19, 2024
@briandfoy briandfoy added Type: compatability make it work like GNU or BSD Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Nov 19, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: chown The chown program Status: released there is a new release with this fix Type: compatability make it work like GNU or BSD Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy