Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chmod: list filename in warning if chmod() fails #813

Merged
merged 1 commit into from
Nov 15, 2024
Merged

chmod: list filename in warning if chmod() fails #813

merged 1 commit into from
Nov 15, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 15, 2024

  • Address the same issue as for previous chgrp commit: 420f8b2
  • The argument list could have 3 files, and chmod() is successful for one but the remaining args fail
  • It would be nice to introduce a regular usage() function in chmod later
%perl chmod 600 /etc/motd wordlist.txt /etc/passwd
chmod: failed to change mode for '/etc/motd': Operation not permitted
chmod: failed to change mode for '/etc/passwd': Operation not permitted

@mknos
chmod: list filename in warning if chmod() fails
37c61cb 
* Address same issue as for previous chgrp commit: 420f8b2
* The argument list could have 3 files, and chmod() is successful for one but the remainder fail
* It would be nice to introduce a regular usage() function in chmod later

%perl chmod 600 /etc/motd wordlist.txt  /etc/passwd 
chmod: failed to change mode for '/etc/motd': Operation not permitted
chmod: failed to change mode for '/etc/passwd': Operation not permitted
@mknos mknos temporarily deployed to automated_testing November 15, 2024 03:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 15, 2024 03:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 15, 2024 03:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 15, 2024 03:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 15, 2024 03:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 15, 2024 03:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 15, 2024 03:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 15, 2024 03:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 15, 2024 03:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 15, 2024 03:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 15, 2024 03:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 15, 2024 03:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 15, 2024 03:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 15, 2024 03:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 15, 2024 03:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 15, 2024 03:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 15, 2024 03:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 15, 2024 03:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 15, 2024 03:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 15, 2024 03:04 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Nov 15, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11849480709

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.069%
Totals Coverage Status
Change from base Build 11833466072: 0.0%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11849480713

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.069%
Totals Coverage Status
Change from base Build 11833466072: 0.0%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: chmod The chmod program labels Nov 15, 2024
@briandfoy briandfoy merged commit aed5703 into briandfoy:master Nov 15, 2024
23 checks passed
@briandfoy briandfoy self-assigned this Nov 15, 2024
@briandfoy briandfoy removed the Priority: low get to this whenever label Nov 15, 2024
@briandfoy briandfoy added the Status: accepted The fix is accepted label Nov 15, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: chmod The chmod program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy