Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ed: basic support for mark (k) command #812

Merged
merged 1 commit into from
Nov 15, 2024
Merged

ed: basic support for mark (k) command #812

merged 1 commit into from
Nov 15, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 15, 2024

  • Mark is a standard feature in ed and it's not very much code to support it
  • Resolving a mark that doesn't exist results in Invalid Address error
  • 1,2kx ---> mark x as 2
  • 1kx ---> mark x as 1
  • kx ---> mark x as CurrentLine (default)
  • 'x,$n ---> run n command from marked line x to end of buffer

@mknos
de: basic support for mark (k) command
79c0427 
* Mark is a standard feature in ed and it's not very much code to support it
* Resolving a mark that doesn't exist results in Invalid Address error
* 1,2kx ---> mark x as 2
* 1kx ---> mark x as 1
* kx ---> mark x as CurrentLine (default)
* 'x,$n ---> run n command from marked line x to end of buffer
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ed The ed program labels Nov 15, 2024
@coveralls
Copy link

coveralls commented Nov 15, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11847953737

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.069%
Totals Coverage Status
Change from base Build 11833466072: 0.0%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy merged commit 2855e11 into briandfoy:master Nov 15, 2024
23 checks passed
@briandfoy
Copy link
Owner

changes: basic support for mark (K) command

@briandfoy briandfoy added the Status: accepted The fix is accepted label Nov 15, 2024
@briandfoy briandfoy removed the Priority: low get to this whenever label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees
No one assigned
Labels
Program: ed The ed program Status: accepted The fix is accepted Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy