Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ed: generic search function #808

Merged
merged 1 commit into from
Nov 13, 2024
Merged

ed: generic search function #808

merged 1 commit into from
Nov 13, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 13, 2024

  • Reduce duplicated code by rolling edSearchForward() and edSearchBackward() into one function
  • While here, remove a comment about GNU ed setting current line for '=' command ("/pattern/=" command in GNU ed does not set current line)

@mknos
ed: generic search function
b4a6b80 
* Reduce duplicated code by rolling edSearchForward() and edSearchBackward() into one function
* While here, remove a comment about GNU ed setting current line for '=' command... "/pattern/=" in GNU ed does not set current line
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ed The ed program labels Nov 13, 2024
@mknos mknos temporarily deployed to automated_testing November 13, 2024 05:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 05:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 05:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 05:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 05:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 05:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 05:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 05:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 05:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 05:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 05:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 05:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 05:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 05:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 05:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 05:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 05:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 05:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 05:50 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 05:51 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Nov 13, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11811449570

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 11791720126: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy self-assigned this Nov 13, 2024
@briandfoy briandfoy merged commit 0ecebca into briandfoy:master Nov 13, 2024
22 of 23 checks passed
@briandfoy briandfoy removed the Priority: low get to this whenever label Nov 13, 2024
@briandfoy briandfoy added the Status: accepted The fix is accepted label Nov 13, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: ed The ed program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy