Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split: allow /0/ pattern split #807

Merged
merged 1 commit into from
Nov 13, 2024
Merged

split: allow /0/ pattern split #807

merged 1 commit into from
Nov 13, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 13, 2024

  • When splitting input file with -p PATTERN, allow pattern to be '0'
  • Probably this is a bad pattern to use, but ignoring -p0 is not correct
%printf "aa\n0\nbb\n0\ncc\n" | perl split -p0
%for f in xaa*; do echo "$f:"; cat $f; done
xaaa:
aa
xaab:
0
bb
xaac:
0
cc

@mknos
split: allow /0/ pattern split
6e60586 
* When splitting input file with -p PATTERN, allow pattern to be '0'
* Probably this is a bad pattern to use, but ignoring -p0 is not correct

%printf "aa\n0\nbb\n0\ncc\n" | perl split -p0
%for f in xaa*; do echo "$f:"; cat $f; done
xaaa:
aa
xaab:
0
bb
xaac:
0
cc
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: split The split program labels Nov 13, 2024
@mknos mknos temporarily deployed to automated_testing November 13, 2024 02:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 02:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 02:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 02:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 02:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 02:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 02:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 02:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 02:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 02:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 02:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 02:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 02:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 02:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 02:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 02:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 02:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 02:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 02:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 02:30 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Nov 13, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11809491323

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 11791720126: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy self-assigned this Nov 13, 2024
@briandfoy briandfoy merged commit 8934637 into briandfoy:master Nov 13, 2024
22 of 23 checks passed
@briandfoy
Copy link
Owner

changes: allow /0/ pattern split (check pattern is defined, not true)

@briandfoy briandfoy added Type: bug an existing feature does not work Status: accepted The fix is accepted and removed Type: enhancement improve a feature that already exists Priority: low get to this whenever labels Nov 13, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: split The split program Status: released there is a new release with this fix Type: bug an existing feature does not work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy