Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply: improve parsing of -a option #806

Merged
merged 1 commit into from
Nov 13, 2024
Merged

apply: improve parsing of -a option #806

merged 1 commit into from
Nov 13, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 13, 2024

  • When testing against OpenBSD, the -a option argument can be given with or without a leading space
  • Allow this version to accept the "-a c" form to avoid confusion
  • Sync usage string with BSD version: "[-a c]" instead of [-ac] which could be confused as grouped options -a and -c
  • If a bad option was given, e.g. -x, print it before the usage string
  • If the argument to -a is >1 character, reject it and terminate the program
  • test1: perl apply -a'!' 'echo HELLO, !1' e*.c # say hello to my e files
  • test2: perl apply -a '!' 'echo HELLO, !1' e*.c # same
  • test3: perl apply 'echo HELLO, %1' e*.c # same, without -a
  • test4: perl apply -a 'oops' 'echo HELLO, !1' e*.c # invalid

@mknos
apply: improve parsing of -a option
9567f3f 
* When testing against OpenBSD, the -a option argument can be given with or without a leading space
* Allow this version to accept "-a c" form to avoid confusion
* Sync usage string with BSD version: "[-a c]" instead of [-ac] which could be confused as grouped options -a and -c
* If a bad option was given, e.g. -x, print the bad option before the usage string
* If the argument to -a is not 1 character, reject it and terminate the program
* test1: perl apply -a'!' 'echo HELLO, !1' e*.c # say hello to my e files
* test2: perl apply -a '!' 'echo HELLO, !1' e*.c # same
* test3: perl apply 'echo HELLO, %1' e*.c # same, without -a
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: apply The apply program labels Nov 13, 2024
@coveralls
Copy link

coveralls commented Nov 13, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11808540377

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 11791720126: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@coveralls
Copy link

coveralls commented Nov 13, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11808540379

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 11791720126: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy self-assigned this Nov 13, 2024
@briandfoy
Copy link
Owner

changes: allow a space after -a so it isn't confused with bundled options

@briandfoy briandfoy merged commit 87636ea into briandfoy:master Nov 13, 2024
22 of 23 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: apply The apply program Status: accepted The fix is accepted Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy