Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chown: allow numeric UID argument #804

Merged
merged 1 commit into from
Nov 13, 2024
Merged

chown: allow numeric UID argument #804

merged 1 commit into from
Nov 13, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 12, 2024

  • This is similar to the patch for chgrp command
  • Fall back to treating numeric argument as a uid if username resolution failed
  • The code surrounding stat() had the same bug as for chgrp, i.e. existing uid=0 was treated as a failed stat()

@mknos
chown: allow numeric UID argument
6fd71bd 
* This is similar to the patch for chgrp command
* Fall back to treating numeric argument as a uid if username resolution failed
* The code surrounding stat() had the same bug as for chgrp, i.e. existing uid=0 was treated as a failed stat()
@github-actions github-actions bot added the Type: enhancement improve a feature that already exists label Nov 12, 2024
@github-actions github-actions bot added the Priority: low get to this whenever label Nov 12, 2024
@github-actions github-actions bot added the Program: chown The chown program label Nov 12, 2024
@coveralls
Copy link

coveralls commented Nov 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11792734128

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 11791720126: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy
Copy link
Owner

changes: allow numeric UID argument

@briandfoy briandfoy merged commit 8e8af73 into briandfoy:master Nov 13, 2024
22 of 23 checks passed
@briandfoy briandfoy self-assigned this Nov 13, 2024
@briandfoy briandfoy removed the Priority: low get to this whenever label Nov 13, 2024
@briandfoy briandfoy added the Status: accepted The fix is accepted label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: chown The chown program Status: accepted The fix is accepted Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy