Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grep: don't automatically decompress #799

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 12, 2024

  • When run on a binary file, grep should search it as a binary file
  • Regular grep should not decompress a file (this version was decompressing based on file extension)
  • Adopt the -Z flag from OpenBSD which makes grep behave as zgrep [1]
  • Sync POD manual
  1. http://man.openbsd.org/grep#Z
%gzip -9k ar # create ar.gz
%perl grep ar ar.gz # original filename stored in binary
grep: ar.gz: binary file matches
%perl grep perl ar.gz # no match
%perl grep -Z perl ar.gz # match after decompression
#!/usr/bin/perl
License: perl

* When run on a binary file, grep should search it as a binary file
* Regular grep should not decompress a file (this version was decompressing based on file extension)
* Adopt the -Z flag from OpenBSD which makes grep behave as zgrep
* Sync POD manual

%gzip -9k ar # create ar.gz
%perl grep ar ar.gz # original filename stored in binary
grep: ar.gz: binary file matches
%perl grep perl ar.gz # no match
%perl grep -Z perl ar.gz # match after decompression
#!/usr/bin/perl
License: perl
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: grep The grep program labels Nov 12, 2024
@coveralls
Copy link

coveralls commented Nov 12, 2024

Pull Request Test Coverage Report for Build 11790844202

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%

Totals Coverage Status
Change from base Build 11774186393: -0.7%
Covered Lines: 350
Relevant Lines: 479

💛 - Coveralls

@briandfoy briandfoy self-assigned this Nov 12, 2024
@briandfoy
Copy link
Owner

changes: add -Z to operate in zgrep mode (don't automatically decompress everything)

@briandfoy briandfoy merged commit 0c0305a into briandfoy:master Nov 12, 2024
22 of 23 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Program: grep The grep program Status: accepted The fix is accepted Type: enhancement improve a feature that already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants