Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chgrp: accept group ID argument #798

Merged
merged 1 commit into from
Nov 12, 2024
Merged

chgrp: accept group ID argument #798

merged 1 commit into from
Nov 12, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 12, 2024

  • The "group" argument to chgrp can be either a name or an ID
  • When testing against GNU and OpenBSD I found that this version did not accept an ID argument
  • Allow numeric ID to be passed to chown()
  • Also fix a problem where uid=0 from stat() was treated as stat() failure; it is normal for uid=0 to be root

@mknos
chgrp: accept group ID argument
52253fe 
* The "group" argument to chgrp can be either a name or an ID
* When testing against GNU and OpenBSD I found that this version did not accept an ID argument
* Allow numeric ID to be passed to chown()
* Also fix a problem where uid=0 from stat() was treated as stat() failure; it is normal for uid=0 to be root
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: chgrp The chgrp program labels Nov 12, 2024
@coveralls
Copy link

coveralls commented Nov 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11790754395

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 11774186393: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy self-assigned this Nov 12, 2024
@briandfoy briandfoy merged commit 7ac2d33 into briandfoy:master Nov 12, 2024
22 of 23 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Nov 12, 2024
@briandfoy
Copy link
Owner

changes: accept group ID argument

@briandfoy briandfoy added the Type: typo spelling, grammar, and other typing mistakes label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: chgrp The chgrp program Status: accepted The fix is accepted Type: enhancement improve a feature that already exists Type: typo spelling, grammar, and other typing mistakes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy