-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cut: consistent field list handling for -f #789
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* handle_b() had been updated with more correct parser for field lists (including sorting fields and ranges) * Move the list-spec parser into its own function and use it in handle_f() for "cut -f" * Output tested against GNU version * test1: echo 'a:b:c:d:e:f' | perl cut -d ':' -f 3,2,2,1 a:b:c * test2: echo 'a:b:c:d:e:f' | perl cut -d ':' -f -2 a:b * test3: echo 'a:b:c:d:e:f' | perl cut -d ':' -f 3 c * test4: echo 'a:b:c:d:e:f' | perl cut -d ':' -f 3- c:d:e:f * test5: printf "a:b:c:d:e:f\nhey\n" | perl cut -d ':' -f 3- c:d:e:f hey * test6: printf "a:b:c:d:e:f\nhey\n" | cut -s -d ':' -f 3- c:d:e:f * test7: printf "a:b:c:d:e:f\n" | perl cut -d ':' -f 100 ["\n" printed]
github-actions
bot
added
Type: enhancement
improve a feature that already exists
Priority: low
get to this whenever
Program: cut
The cut program
labels
Nov 8, 2024
mknos
temporarily deployed
to
automated_testing
November 8, 2024 01:31
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 8, 2024 01:31
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 8, 2024 01:31
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 8, 2024 01:31
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 8, 2024 01:31
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 8, 2024 01:31
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 8, 2024 01:31
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 8, 2024 01:31
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 8, 2024 01:31
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 8, 2024 01:31
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 8, 2024 01:31
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 8, 2024 01:31
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 8, 2024 01:31
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 8, 2024 01:31
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 8, 2024 01:31
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 8, 2024 01:31
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 8, 2024 01:31
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 8, 2024 01:31
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 8, 2024 01:31
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 8, 2024 01:32
— with
GitHub Actions
Inactive
Pull Request Test Coverage Report for Build 11734403755Details
💛 - Coveralls |
briandfoy
approved these changes
Nov 8, 2024
changes: handle -f consistently |
briandfoy
added
Status: accepted
The fix is accepted
and removed
Priority: low
get to this whenever
labels
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Program: cut
The cut program
Status: accepted
The fix is accepted
Type: enhancement
improve a feature that already exists
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handle_b() had been updated with more correct parser for field lists (including sorting fields and ranges)
Move the list-spec parser into its own function and use it in handle_f() for "cut -f"
handle_f() was looping over
@hunk
multiple times (incorrectly) when list-spec contained a commaOutput tested against GNU version
test1: echo 'a:b:c:d:e:f' | perl cut -d ':' -f 3,2,2,1
a:b:c
test2: echo 'a:b:c:d:e:f' | perl cut -d ':' -f -2
a:b
test3: echo 'a:b:c:d:e:f' | perl cut -d ':' -f 3
c
test4: echo 'a:b:c:d:e:f' | perl cut -d ':' -f 3-
c:d:e:f
test5: printf "a:b:c:d:e:f\nhey\n" | perl cut -d ':' -f 3-
c:d:e:f
hey
test6: printf "a:b:c:d:e:f\nhey\n" | cut -s -d ':' -f 3-
c:d:e:f
test7: printf "a:b:c:d:e:f\n" | perl cut -d ':' -f 100
["\n" printed]