Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ed: allow delete with g// and v// #780

Merged
merged 1 commit into from
Nov 5, 2024
Merged

ed: allow delete with g// and v// #780

merged 1 commit into from
Nov 5, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 4, 2024

  • Rewrite how global command (g) is interpreted: for global mode @adrs will contain the line addresses to be processed (non-contiguous)
  • Now the command can be called once and the @inbuf kludge can go away
  • Support global mode in edPrint() for commands l,n,p
  • Support global mode in edDelete() for command d
  • When deleting in global mode the addresses are processed backwards so the 1st splice doesn't upset the subsequent array offsets saved in @adrs
  • Document in pod that "d" can now be used with v// and g//
  • Bump version
  • test1: 1,7g/t/d ---> delete lines matching /t/ only between lines 1 and 7
  • test2: v/printf/d ---> delete all lines not matching /printf/

@mknos
ed: allow delete with g// and v//
539155c 
* Rewrite how global command (g) is interpreted: for global mode adrs-list will contain the line addresses to be processed (non-contiguous)
* Now the command can be called once and the inbuf-list kludge can go away
* Support global mode in edPrint() for commands l,n,p
* Support global mode in edDelete() for command d
* When deleting in global mode the addresses are processed backwards so the 1st splice doesn't upset the subsequent array offsets saved in adrs-list
* Document in pod that "d" can now be used with v// and g//
* Bump version
* test1: 1,7g/t/d ---> delete lines matching /t/ only between lines 1 and 7
* test2: v/printf/d   ---> delete all lines not matching /printf/
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ed The ed program labels Nov 4, 2024
@mknos mknos temporarily deployed to automated_testing November 4, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 4, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 4, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 4, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 4, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 4, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 4, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 4, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 4, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 4, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 4, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 4, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 4, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 4, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 4, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 4, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 4, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 4, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 4, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 4, 2024 05:20 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Nov 4, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11658530133

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 11655461453: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy self-assigned this Nov 5, 2024
@briandfoy briandfoy merged commit a452a70 into briandfoy:master Nov 5, 2024
22 of 23 checks passed
@briandfoy briandfoy removed the Priority: low get to this whenever label Nov 5, 2024
@briandfoy briandfoy added the Status: accepted The fix is accepted label Nov 5, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: ed The ed program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy