Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: standard exit code #779

Merged
merged 1 commit into from
Nov 3, 2024
Merged

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 3, 2024

  • Patch::error() returns $ERROR
  • In Patch::print_rejects(), $ERROR is incremented if rejected pieces are found during processing
  • No other function updates $ERROR, so Patch::error() indicates if rejects are present
  • die() calls are wrapped by an END-block which sets exit code to 1; follow standard and set it to 2 [1]
  • Failure to detect a diff in the input is considered an error; call die() to indicate this
  • Add EXIT STATUS section to pod as done in other scripts
  • test1: "perl patch -x" ---> bad option, exit(2)
  • test2: "echo BOGUS-DIFF-123 > bogus.diff && perl patch xargs bogus.diff" ---> no diff found, exit(2)
  • test3: "perl patch dirname sort.diff" ---> mismatched diff which can't be applied, exit(1)
  • test4: "perl patch a.c correct.diff" ---> diff applies with no failed parts, exit(0)
  1. https://pubs.opengroup.org/onlinepubs/007904975/utilities/patch.html

* Patch::error() returns $ERROR
* In Patch::print_rejects(), $ERROR is incremented if rejected pieces are found during processing
* No other function updates $ERROR, so Patch::error() indicates if rejects are present
* die() cals are wrapped by an END-block which sets exit code to 1; follow standard and set it to 2 [1]
* Failure to detect a diff in the input is considered an error; call die() to indicate this
* test1: "perl patch -x" ---> bad option, exit(2)
* test2: "echo "BOGUS-DIFF-123" > bogus.diff && perl patch xargs bogus.diff" ---> no diff found, exit(2)
* test3: "perl patch dirname sort.diff" ---> mismatched diff which can't be applied, exit(1)
* test4: "perl patch a.c correct.diff" ---> diff applies with no failed parts, exit(0)

1. https://pubs.opengroup.org/onlinepubs/007904975/utilities/patch.html
@mknos mknos temporarily deployed to automated_testing November 3, 2024 09:58 — with GitHub Actions Inactive
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: patch The patch program labels Nov 3, 2024
@mknos mknos temporarily deployed to automated_testing November 3, 2024 09:58 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 3, 2024 09:58 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 3, 2024 09:58 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 3, 2024 09:58 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 3, 2024 09:58 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 3, 2024 09:58 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 3, 2024 09:58 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 3, 2024 09:58 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 3, 2024 09:58 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 3, 2024 09:58 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 3, 2024 09:58 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 3, 2024 09:58 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 3, 2024 09:58 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 3, 2024 09:58 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 3, 2024 09:58 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 3, 2024 09:58 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 3, 2024 09:58 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 3, 2024 09:58 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 3, 2024 09:59 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Nov 3, 2024

Pull Request Test Coverage Report for Build 11650380175

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%

Totals Coverage Status
Change from base Build 11639173728: -0.7%
Covered Lines: 350
Relevant Lines: 479

💛 - Coveralls

bin/patch Show resolved Hide resolved
@briandfoy briandfoy merged commit 6ee9759 into briandfoy:master Nov 3, 2024
22 of 23 checks passed
@briandfoy
Copy link
Owner

changes: note that patch exists with 0 for success

@briandfoy briandfoy added the Type: documentation fix the docs label Nov 3, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Nov 3, 2024
@briandfoy briandfoy self-assigned this Nov 3, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Program: patch The patch program Status: released there is a new release with this fix Type: documentation fix the docs Type: enhancement improve a feature that already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants