-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
patch: standard exit code #779
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mknos
commented
Nov 3, 2024
•
edited
Loading
edited
- Patch::error() returns $ERROR
- In Patch::print_rejects(), $ERROR is incremented if rejected pieces are found during processing
- No other function updates $ERROR, so Patch::error() indicates if rejects are present
- die() calls are wrapped by an END-block which sets exit code to 1; follow standard and set it to 2 [1]
- Failure to detect a diff in the input is considered an error; call die() to indicate this
- Add EXIT STATUS section to pod as done in other scripts
- test1: "perl patch -x" ---> bad option, exit(2)
- test2: "echo BOGUS-DIFF-123 > bogus.diff && perl patch xargs bogus.diff" ---> no diff found, exit(2)
- test3: "perl patch dirname sort.diff" ---> mismatched diff which can't be applied, exit(1)
- test4: "perl patch a.c correct.diff" ---> diff applies with no failed parts, exit(0)
- https://pubs.opengroup.org/onlinepubs/007904975/utilities/patch.html
* Patch::error() returns $ERROR * In Patch::print_rejects(), $ERROR is incremented if rejected pieces are found during processing * No other function updates $ERROR, so Patch::error() indicates if rejects are present * die() cals are wrapped by an END-block which sets exit code to 1; follow standard and set it to 2 [1] * Failure to detect a diff in the input is considered an error; call die() to indicate this * test1: "perl patch -x" ---> bad option, exit(2) * test2: "echo "BOGUS-DIFF-123" > bogus.diff && perl patch xargs bogus.diff" ---> no diff found, exit(2) * test3: "perl patch dirname sort.diff" ---> mismatched diff which can't be applied, exit(1) * test4: "perl patch a.c correct.diff" ---> diff applies with no failed parts, exit(0) 1. https://pubs.opengroup.org/onlinepubs/007904975/utilities/patch.html
mknos
temporarily deployed
to
automated_testing
November 3, 2024 09:58 — with
GitHub Actions
Inactive
github-actions
bot
added
Type: enhancement
improve a feature that already exists
Priority: low
get to this whenever
Program: patch
The patch program
labels
Nov 3, 2024
mknos
temporarily deployed
to
automated_testing
November 3, 2024 09:58 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 3, 2024 09:58 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 3, 2024 09:58 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 3, 2024 09:58 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 3, 2024 09:58 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 3, 2024 09:58 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 3, 2024 09:58 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 3, 2024 09:58 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 3, 2024 09:58 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 3, 2024 09:58 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 3, 2024 09:58 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 3, 2024 09:58 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 3, 2024 09:58 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 3, 2024 09:58 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 3, 2024 09:58 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 3, 2024 09:58 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 3, 2024 09:58 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 3, 2024 09:58 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 3, 2024 09:59 — with
GitHub Actions
Inactive
Pull Request Test Coverage Report for Build 11650380175Details
💛 - Coveralls |
briandfoy
approved these changes
Nov 3, 2024
changes: note that patch exists with 0 for success |
briandfoy
added
Status: accepted
The fix is accepted
and removed
Priority: low
get to this whenever
labels
Nov 3, 2024
briandfoy
added
Status: released
there is a new release with this fix
and removed
Status: accepted
The fix is accepted
labels
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Program: patch
The patch program
Status: released
there is a new release with this fix
Type: documentation
fix the docs
Type: enhancement
improve a feature that already exists
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.