Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kill: reject undocumented -L #778

Merged
merged 1 commit into from
Nov 1, 2024
Merged

kill: reject undocumented -L #778

merged 1 commit into from
Nov 1, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 1, 2024

  • The pod manual doesn't mention -L
  • Follow BSD version and raise an error for -L, which is not standardised [1]
  • With this patch kill will exit(1) but it will show signal listing (by default for bad signal spec)
  • While here, write siglist() loop in a less noisy way
  1. https://pubs.opengroup.org/onlinepubs/009696799/utilities/kill.html

@mknos
kill: reject undocumented -L
9aaa64a 
* The pod manual doesn't mention -L
* Follow BSD version and raise an error for -L, which is not standardised [1]
* With this patch kill will exit(1) but it will show signal listing (by default for bad signal spec)

1. https://pubs.opengroup.org/onlinepubs/009696799/utilities/kill.html
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: kill The kill program labels Nov 1, 2024
@mknos mknos temporarily deployed to automated_testing November 1, 2024 07:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 1, 2024 07:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 1, 2024 07:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 1, 2024 07:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 1, 2024 07:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 1, 2024 07:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 1, 2024 07:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 1, 2024 07:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 1, 2024 07:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 1, 2024 07:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 1, 2024 07:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 1, 2024 07:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 1, 2024 07:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 1, 2024 07:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 1, 2024 07:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 1, 2024 07:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 1, 2024 07:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 1, 2024 07:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 1, 2024 07:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 1, 2024 07:08 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Nov 1, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11625746955

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.069%
Totals Coverage Status
Change from base Build 11615685052: 0.0%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy merged commit 1e62033 into briandfoy:master Nov 1, 2024
23 checks passed
@briandfoy
Copy link
Owner

changes: remove undocumented -L option, which was the same as -l (lowercase)

@briandfoy briandfoy removed the Priority: low get to this whenever label Nov 1, 2024
@briandfoy briandfoy added the Status: accepted The fix is accepted label Nov 1, 2024
@briandfoy briandfoy self-assigned this Nov 1, 2024
@briandfoy briandfoy added Type: bug an existing feature does not work Type: documentation fix the docs and removed Type: enhancement improve a feature that already exists labels Nov 1, 2024
@briandfoy briandfoy added the Type: compatability make it work like GNU or BSD label Nov 13, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: kill The kill program Status: released there is a new release with this fix Type: bug an existing feature does not work Type: compatability make it work like GNU or BSD Type: documentation fix the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy