Adds precision argument to chroma effect #141
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned in issue 80 some devices will add black areas when using chroma due to problems when rounding the alpha value. This pull request adds a precision argument to the chroma effect to easily change the rounding factor to fit specific devices:
For example: on the iPad 2 with Safari 9, iOS 9.3 I had to change the precision to 0.01 for the chroma effect to work reliably.
The default value is the original 0.00001 so this shouldn't break anything for existing scripts.
chroma = seriously.effect('chroma');
chroma.precision = 0.01;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in issue #80 some devices will add black areas when using chroma due to problems when rounding the alpha value. This pull request adds a precision argument to the chroma effect to easily change the rounding factor to fit specific devices.
The default value is the original 0.00001 so this shouldn't break anything for existing scripts.
For example: on the iPad 2 with Safari 9, iOS 9.3 I had to change the precision to 0.01 for the chroma effect to work reliably.