Rename variables for clarity, update default values #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to bring clarity with:
default_celery_worker_*tocelery_worker_*(since there is only 1 worker, this keeps things clear between celery_beat and celery_worker and avoids the confusion of variables likedefault_celery_worker_memoryapi_*tobackend_*(memory, cpu, command)This PR also changes the lowers the memory and CPU allocated.
As an aside, I've been running gunicorn with 0.01 vCPU (
10CPU Units) and 512 MB memory and haven't had any issues! We don't need to go that low necessarily, but it's good to know how much we might need to set defaults.