New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add build timeouts #3172

Merged

charmander merged 1 commit into brianc:master from alxndrsn:ci-build-timeouts

Mar 15, 2024

Contributor

alxndrsn commented Mar 14, 2024

This should prevent runaway builds.

I noticed this issue when working on a fork of #2836. Example builds with/without these timeouts:

6 hours: https://github.com/alxndrsn/node-postgres/actions/runs/8277192701
10 minutes: https://github.com/alxndrsn/node-postgres/actions/runs/8277388503

These timeouts are 4-5x what a current healthy build takes.


          ci: add build timeouts

55395aa

This should prevent runaway builds.

I noticed this issue when working on a fork of brianc#2836.  Example builds with/without these timeouts:

1. 6 hours: https://github.com/alxndrsn/node-postgres/actions/runs/8277192701
2. 10 minutes: https://github.com/alxndrsn/node-postgres/actions/runs/8277388503

These timeouts are 4-5x what a current healthy build takes.

charmander approved these changes

View reviewed changes

charmander merged commit 641ab43 into brianc:master

6 checks passed

alxndrsn deleted the ci-build-timeouts branch

March 15, 2024 05:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet