Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wheel build #287

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Fix wheel build #287

merged 2 commits into from
Dec 11, 2023

Conversation

oyvinev
Copy link
Contributor

@oyvinev oyvinev commented Dec 11, 2023

I noticed that pypi hasn't been updated with the latest versions, and that 3.12 wheels are not being built.

This branch aims to fix this.

  • Fix issue where curl don't follow symlinks
  • Use python 3.12 to build wheels. The latest cibuildwheels doesn't support 3.7, and thus an older version of cibuildwheels is used. This older version doesn't create python 3.12 wheels.

Workflow: https://github.com/oyvinev/cyvcf2/actions/runs/7168362176

image
image
image

@brentp brentp merged commit 85ecbc2 into brentp:main Dec 11, 2023
8 checks passed
@brentp
Copy link
Owner

brentp commented Dec 11, 2023

Thanks @oyvinev this is amazing !

@graphenn , pinging you here in case this affects your intended PR to split htslib builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants