-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix some errors in github action, and add python 3.12 #286
Conversation
Add build test case for the offical python docker image, arm64/amd64 + debian #274 It can pass pytest if remove test_write_missing_contig case in test_reader.py (the left issue). Arm64 + debain build issue also fixed. |
I have found a solution to decouple the compilation of cyvcf2 and htslib, which now enables the upgrade of htslib. Additionally, by statically linking to the htslib library, we can avoid redundant compilations. This approach ensures a smoother and more efficient development process. I have tested htslib 1.18, but the test_write_missing_contig test case still error. Do you want me to submit this changes here or later? |
everything works now! And I will submit decouple the compilation of cyvcf2 and htslib at another PR later. |
This is amazing! thanks so much. PR for decoupling would be great! |
not all heroes wear capes, but, fittingly, your avatar does. 🦸 |
Not all issues fixed. The left issue can be test with code below.
It may be same issue with these, on htslib 1.18
Fixed possible double frees when handling errors in bcf_hdr_add_hrec(), if particular memory allocations fail. (PR samtools/htslib#1637)
Ensure that bcf_hdr_remove() clears up all pointers to the items removed from dictionaries. Failing to do this could have resulted in a call requesting a deleted item via bcf_hdr_get_hrec() returning a stale pointer. (PR samtools/htslib#1637)
I tried but failed to upgrade htslib version.