add notes about keeping the lowest supported numpy version in sync wi…

…th the CI
brentp · Jun 18, 2024 · 1c2f6fe · 1c2f6fe
1 parent 22ccd3e
commit 1c2f6fe
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -110,6 +110,7 @@ jobs:
         run: |
           pytest --cov cyvcf2 --cov-report term-missing
 
+      # make sure to keep this numpy version in sync with setup.py
       - name: Test with oldest numpy that we support
         if: contains(fromJson('["3.7"]'), matrix.python-version)
         run: |

diff --git a/setup.py b/setup.py
@@ -290,6 +290,7 @@ def run(self):
         ],
     ),
     python_requires=">=3.7",
+    # make sure to keep this numpy version in sync with build.yml
     install_requires=["numpy>=1.16.0", "coloredlogs", "click"],
     include_package_data=True,
     zip_safe=False,