Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Revamp websites docs to use Lift #1060
[DOCS] Revamp websites docs to use Lift #1060
Changes from 3 commits
7fe2915
a1ceb31
e2625a8
4ebbef1
4fc8f77
94e9fd3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is how it works in Laravel but I'm really not sure as I'm not using it. Would be helpful if someone could confirm this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GrahamCampbell maybe you can confirm whether those paths look correct? 🙏
This should be the list of static assets in a brand new/standard Laravel app. These static assets would be served by CloudFront + S3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the manifest.json file from the public folder will need to be shipped in the lambda image for this to work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unfortunately, that path can be changed in php land. will either be located at
public/mix-manifest.json
orpublic/{artbirarypath}mix-manifest.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For arbitrary path it makes sense that users that know how to customize it will know to also reflect such customization here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I agree with Marco.
Said differently, we're looking for the "out of the box" config laravel mix provides.
But if the manifest needs to be included on the Lambda deployment package, we might want to state it in this doc or add it to the package.patterns config provided by the Laravel bridge.
We went with the second one in the Symfony Bridge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good then, because
public/mix-manifest.json
is not excluded from the Lambda deployment by default: https://github.com/brefphp/laravel-bridge/blob/master/config/serverless.yml#L15-L19So it seems we are all good to merge here.
Thanks for the feedback both of you!