Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add composer to the dev images #173

Merged
merged 1 commit into from
May 3, 2024
Merged

Add composer to the dev images #173

merged 1 commit into from
May 3, 2024

Conversation

mnapoli
Copy link
Member

@mnapoli mnapoli commented May 3, 2024

Helpful to install prod dependencies before deploying (and run in the same env as prod).

@mnapoli mnapoli merged commit 7815db4 into main May 3, 2024
9 checks passed
@mnapoli mnapoli deleted the add-composer branch May 3, 2024 13:48
@@ -37,6 +37,9 @@ EXPOSE 8000
# Add `php/conf.dev.d` to the path where PHP looks for configuration files
ENV PHP_INI_SCAN_DIR="/opt/bref/etc/php/conf.d:/var/task/php/conf.d:/var/task/php/conf.dev.d"

# Add composer
COPY --link --from=composer/composer:2-bin /composer /usr/bin/composer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we include the full version, as cache-buster, and to allow explicit upgrading, to ensure a specific composer version is picked up?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather not to keep things simple, this is composer, pretty stable, and in a dev image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants