Allow interface values in notification payload #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangeross
reviewed
Jan 17, 2024
http/router.go
Outdated
| @@ -48,7 +48,7 @@ func (p *LnurlPayInfoPayload) ToNotification(query *MobilePushWebHookQuery) *not | |||
| type LnurlPayInvoicePayload struct { | |||
| Template string `json:"template" binding:"required,eq=lnurlpay_invoice"` | |||
| Data struct { | |||
| Amount string `json:"amount" binding:"required"` | |||
| Amount int `json:"amount" binding:"required"` | |||
There was a problem hiding this comment.
Should we validate the amount here, or should the validation take place in the application/SDK? I've seen the breez-lnurl server parses a uint, but I would say breez-lnurl and notify should not be dependent on each other to validate data, especially when vendors have differing implementations.
Suggested change
| Amount int `json:"amount" binding:"required"` | |
| Amount int `json:"amount" binding:"required,min=1"` |
dangeross
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change to allow generic json as payload rather than limit to string values.