remove pasting handling #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ubbabeck do you mind sharing a before/after video? because it is not clear to me what is the difference in the UX you got by these changes. |
|
Here is an example of how they differ @ademar111190 New flownew_paste_flow.movOld flowold_paste_flow.mov |
ubbabeck
force-pushed
the
609-multiple-pasting
branch
from
a8e12ed
to
5bf89bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr removes the pasting logic of the send_options_bottom_sheet.dart to mimic the behaviour of breezmobile.
I believe this can be removed since the inputhandler handles the data if the user has something in their clipboard and in my opinion the UX is also better now. The user might want to manually write in an lighting address while having an invoice in the clipboard.