Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

display error when invoice is paid #627

Merged
merged 1 commit into from
Sep 21, 2023
Merged

display error when invoice is paid #627

merged 1 commit into from
Sep 21, 2023

Conversation

ubbabeck
Copy link
Contributor

Display a flushbar when there is a FfiException when paying an invoice.

invoice_paid.mov

@ubbabeck ubbabeck self-assigned this Sep 15, 2023
erdemyerebasmaz
erdemyerebasmaz requested changes Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@erdemyerebasmaz erdemyerebasmaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, have two suggestions.

lib/widgets/payment_dialogs/processing_payment_dialog.dart Outdated Show resolved Hide resolved
lib/widgets/payment_dialogs/processing_payment_dialog.dart Show resolved Hide resolved
@ubbabeck ubbabeck merged commit dd8d828 into main Sep 21, 2023
1 check passed
@ubbabeck ubbabeck deleted the paid-invoice branch September 21, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ademar111190 ademar111190 ademar111190 approved these changes

@erdemyerebasmaz erdemyerebasmaz erdemyerebasmaz approved these changes

@roeierez roeierez Awaiting requested review from roeierez

Assignees

@ubbabeck ubbabeck

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ubbabeck @ademar111190 @erdemyerebasmaz