larger sceen support for sending #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
issue-619-bad-ui.mov |
ubbabeck
force-pushed
the
619-bad-ui-when-sending
branch
from
18db0dc
to
5bbe266
Compare
lib/routes/home/widgets/bottom_actions_bar/enter_payment_info_dialog.dart
Outdated
Show resolved
Hide resolved
ubbabeck
force-pushed
the
619-bad-ui-when-sending
branch
from
5bbe266
to
db38951
Compare
ademar111190
requested changes
Sep 22, 2023
There was a problem hiding this comment.
The buttons being one on top of the other is not a bug, it is how the dialog adapts itself when there is not enough available space for adding the buttons in the same row.
That is especially useful when we support multiple languages, e.g.:
- English: "approve"/"cancel" (13 chars)
- French: "approuver"/"annuler" (16 chars)
We can have scenarios where 13 chars fit in the same row but 16 do not.
The bug reported on #619 seems to be a problem with padding, we are not padding properly so the final space for the button is not what it looks like to be
ubbabeck
force-pushed
the
619-bad-ui-when-sending
branch
2 times, most recently
from
a612ecc
to
1d8c90b
Compare
|
Since latest rebase this is how it looks. |
ubbabeck
changed the title
ademar111190
approved these changes
Sep 25, 2023
lib/routes/home/widgets/bottom_actions_bar/enter_payment_info_dialog.dart
Outdated
Show resolved
Hide resolved
ubbabeck
force-pushed
the
619-bad-ui-when-sending
branch
from
1d8c90b
to
d0a25cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #619.