Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

618 visual feedback dynamic fee UI when lsp does not support opening channels #620

Merged
merged 6 commits into from
Sep 12, 2023
Merged

618 visual feedback dynamic fee UI when lsp does not support opening channels #620

merged 6 commits into from
Sep 12, 2023

Conversation

ubbabeck
Copy link
Contributor

@ubbabeck ubbabeck commented Aug 16, 2023 •
edited
Loading

About pr

Fixes #618

  • Remove warning box when channel creation is not possible for swap.
  • Not let user receive more than maxInboundLiquidity if channel creation is unavailable.
  • Display warning if user tries to receive more than maxInboundLiquidity
  • If inbound liquidity is 0, disable creating an invoice until connected LSP supports opening channels
  • Update translations

@ubbabeck ubbabeck self-assigned this Aug 16, 2023
@ubbabeck ubbabeck linked an issue Aug 16, 2023 that may be closed by this pull request
[Visual feedback] Dynamic Fee UI when LSP does not support opening channels #618
Closed
@ubbabeck ubbabeck force-pushed the 618-visual-feedback-dynamic-fee-ui-when-lsp-does-not-support-opening-channels branch 2 times, most recently from 1540ecd to d2ffe43 Compare August 18, 2023 07:53
@ubbabeck ubbabeck mentioned this pull request Aug 18, 2023
Merged
@ubbabeck ubbabeck force-pushed the 618-visual-feedback-dynamic-fee-ui-when-lsp-does-not-support-opening-channels branch from d2ffe43 to e09c89d Compare August 18, 2023 13:32
@ubbabeck ubbabeck changed the title [WIP] 618 visual feedback dynamic fee UI when lsp does not support opening channels 618 visual feedback dynamic fee UI when lsp does not support opening channels Aug 18, 2023
@ubbabeck ubbabeck force-pushed the 618-visual-feedback-dynamic-fee-ui-when-lsp-does-not-support-opening-channels branch from e09c89d to 8deee88 Compare August 18, 2023 13:42
@ubbabeck ubbabeck requested a review from roeierez August 18, 2023 13:43
@ubbabeck ubbabeck marked this pull request as ready for review August 18, 2023 13:43
@ubbabeck ubbabeck force-pushed the 618-visual-feedback-dynamic-fee-ui-when-lsp-does-not-support-opening-channels branch from 8deee88 to 6da042d Compare August 18, 2023 13:45
@ubbabeck ubbabeck force-pushed the 618-visual-feedback-dynamic-fee-ui-when-lsp-does-not-support-opening-channels branch from 7388c8d to 9447116 Compare August 18, 2023 14:44
roeierez
roeierez requested changes Aug 20, 2023
View reviewed changes
lib/routes/create_invoice/create_invoice_page.dart Outdated Show resolved Hide resolved
lib/bloc/account/account_bloc.dart Outdated Show resolved Hide resolved
@ubbabeck ubbabeck requested a review from roeierez August 21, 2023 08:48
@ubbabeck
Copy link
Contributor Author

Feedback with active channel and inbound liquidity

visual_feedback.mov

Feedback with no active channels, but lsp selected.

visual_feedback_no_channel.mov

@ubbabeck ubbabeck requested a review from kingonly August 21, 2023 08:58
@kingonly
Copy link
Member

LGTM

@ubbabeck ubbabeck force-pushed the 618-visual-feedback-dynamic-fee-ui-when-lsp-does-not-support-opening-channels branch from 0dfa941 to 21e1e94 Compare August 21, 2023 09:13
@ubbabeck ubbabeck merged commit 0335064 into main Sep 12, 2023
1 check passed
@erdemyerebasmaz erdemyerebasmaz deleted the 618-visual-feedback-dynamic-fee-ui-when-lsp-does-not-support-opening-channels branch November 16, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erdemyerebasmaz erdemyerebasmaz erdemyerebasmaz approved these changes

@ademar111190 ademar111190 Awaiting requested review from ademar111190

@roeierez roeierez Awaiting requested review from roeierez

@kingonly kingonly Awaiting requested review from kingonly

Assignees

@ubbabeck ubbabeck

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Visual feedback] Dynamic Fee UI when LSP does not support opening channels
4 participants
@ubbabeck @kingonly @erdemyerebasmaz @roeierez