Support pasting LNURL #593

erdemyerebasmaz · 2023-07-05T22:28:06Z

This PR addresses

Support pasting LNURL #591

Any input that can be handled by our InputHandler is now supported via "Paste Invoice or ID" option.

If input data can't be handled(unsupported input type, empty device clipboard) EnterPaymentInfoDialog will be displayed so users can manually enter their input.

This input will also be validated using parseInput API of SDK and checked against supported input types, an "Unsupported input" error message is shown for unsupported input types(Bitcoin Addresses).

Changelist:

Support all input types that can be handled by our InputHandler "Paste Invoice or ID" and EnterPaymentInfoDialog
Handle input on clicking "Paste Invoice or ID"
Update breez_translations for unsupported input's error message
Expose parseInput API through InputBloc
- Remove utils/lnurl.dart as it's made obsolete by parsing inputs through SDK

ubbabeck

If a user copies the the nodeID@ipaddrress:port we do not recognise it being a node ID.

Do we wish to handle this here in C-breez or perhaps the SDK can handle this, what do you think?

Apart from this minor issue

Looks good to me 🥳

ubbabeck

Opened an issue in breez-sdk where we can handle this nodeID@address format issue instead breez/breez-sdk-greenlight#299

ubbabeck · 2023-07-06T17:31:53Z

@erdemyerebasmaz after discussing with the team we decided that handling nodeURI should handle at in C-breez since this is how we do it in Breezmobile. I added this checking in the latest commit 3083a76

ok300 · 2023-07-06T18:39:52Z

I added this logic in the SDK as well: breez/breez-sdk-greenlight#301

If you'd rather use that, then it's no need to handle this in the UI and you can revert the last commit here.

ubbabeck · 2023-07-06T18:55:19Z

I added this logic in the SDK as well: breez/breez-sdk-greenlight#301

If you'd rather use that, then it's no need to handle this in the UI and you can revert the last commit here.

Awesome. I will revert the latest commit. Thank you🙏

erdemyerebasmaz · 2023-07-06T23:26:28Z

Context for latest changes with `222c64c`

Even though this function is named paste tapped it assumes that the latest inputData on InputBloc's InputState comes from device's clipboard stream.

This caused unwanted behavior such as handling the existing inputData on InputBloc's InputState before permission is given to read clipboard value on iOS 14+ devices.

_pasteTapped, which renamed to _pasteFromClipboard now only handles the latest clipboard data and EnterPaymentInfoDialog is opened if:

there's an error getting the clipboard data,
clipboard data is empty,
clipboard data can't be parsed,
parsed clipboard data can't be handled(unsupported type),

⚠️ This logic looks really ugly and needs a refactor on multiple parts. ⚠️

Related changes:

A loader is displayed when clipboard data is being retrieved, parsed & handled. 88f17ee

ubbabeck

Looks good!

Tested on android emulator. NodeURI works too 👍

ademar111190 · 2023-07-07T14:28:12Z

lib/routes/home/home_page.dart

@@ -34,17 +34,18 @@ class HomeState extends State<Home> with AutoLockMixin, HandlerContextProvider {
  final GlobalKey firstPaymentItemKey = GlobalKey();
  final ScrollController scrollController = ScrollController();
  final handlers = <Handler>[];
+  late final InputHandler inputHandler = InputHandler(


This will break the lifecycle again.

I think SendOptionsBottomSheet should create its own InputHandler dealing with the lifecycle there.

A possibility is a duplication of event handling as there will be 2 or more InputHandlers. We should think of a mechanism to avoid that.

erdemyerebasmaz · 2023-07-10T06:49:48Z

This will break the lifecycle again.

I think SendOptionsBottomSheet should create its own InputHandler dealing with the lifecycle there.

A possibility is a duplication of event handling as there will be 2 or more InputHandlers. We should think of a mechanism to avoid that.

⚠️ Do not merge until lifecycle problem is addressed. ⚠️

erdemyerebasmaz · 2023-07-11T08:09:15Z

InputHandler changes are reverted and lifecycle issue is resolved.

Clipboard item is parsed and passed to InputBloc if it's a supported type.
The clipboard item will be parsed on InputBloc again but there's no way to communicate if it was a supported type or not to open EnterPaymentInfoDialog from the UI w/o the use of async actions and altering InputBloc further.

- Update breez_translations for unsupported input's error message - Expose parseInput api through InputBloc - Remove utils/lnurl.dart

Handle input on clicking "Paste Invoice or ID" Pass clipboard item to input bloc if it's a supported input type Revert inputHandler changes Display a loader when clipboard data is being retrieved, parsed & handled Close bottom sheet upon clicking 'Paste Invoice or ID' button

erdemyerebasmaz requested review from ademar111190, roeierez and ubbabeck July 5, 2023 22:28

erdemyerebasmaz force-pushed the 591-support-pasting-lnurl branch from 54f7de6 to 5170f43 Compare July 5, 2023 22:33

erdemyerebasmaz linked an issue Jul 5, 2023 that may be closed by this pull request

Support pasting LNURL #591

Closed

erdemyerebasmaz added this to the v0.1.0-alpha milestone Jul 5, 2023

erdemyerebasmaz added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 5, 2023

ubbabeck reviewed Jul 6, 2023

View reviewed changes

ubbabeck approved these changes Jul 6, 2023

View reviewed changes

ubbabeck force-pushed the 591-support-pasting-lnurl branch from 7cfbfaf to 3083a76 Compare July 6, 2023 17:39

ubbabeck force-pushed the 591-support-pasting-lnurl branch from f8267c3 to 8c5c246 Compare July 6, 2023 20:49

erdemyerebasmaz force-pushed the 591-support-pasting-lnurl branch from 0317481 to 222c64c Compare July 6, 2023 23:25

erdemyerebasmaz requested a review from ubbabeck July 7, 2023 07:06

ubbabeck approved these changes Jul 7, 2023

View reviewed changes

ademar111190 requested changes Jul 7, 2023

View reviewed changes

erdemyerebasmaz marked this pull request as draft July 11, 2023 06:16

erdemyerebasmaz force-pushed the 591-support-pasting-lnurl branch 3 times, most recently from 485e095 to 2101306 Compare July 11, 2023 08:07

erdemyerebasmaz marked this pull request as ready for review July 11, 2023 08:09

erdemyerebasmaz requested review from ademar111190 and ubbabeck July 11, 2023 08:09

roeierez approved these changes Jul 13, 2023

View reviewed changes

ubbabeck and others added 4 commits July 13, 2023 17:41

correct cancel text for spontaneous payment

a401c3b

Refactor Send to BTC Address action

5fdef96

Support pasting LNURL #591

746bbc6

- Update breez_translations for unsupported input's error message - Expose parseInput api through InputBloc - Remove utils/lnurl.dart

erdemyerebasmaz force-pushed the 591-support-pasting-lnurl branch from 2101306 to 88105d4 Compare July 13, 2023 14:41

Fix "This BuildContext is no longer valid." issue

30c84c9

erdemyerebasmaz merged commit 4d0fbfe into main Jul 13, 2023
1 check passed

ubbabeck mentioned this pull request Jul 17, 2023

Pasting to CBreez from WoS - CBreez is closed before pasting (iOS) #594

Closed

erdemyerebasmaz deleted the 591-support-pasting-lnurl branch September 27, 2023 15:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support pasting LNURL #593

Support pasting LNURL #593

erdemyerebasmaz commented Jul 5, 2023 •

edited

Loading

ubbabeck left a comment •

edited

Loading

ubbabeck left a comment

ubbabeck commented Jul 6, 2023 •

edited

Loading

ok300 commented Jul 6, 2023

ubbabeck commented Jul 6, 2023

erdemyerebasmaz commented Jul 6, 2023 •

edited

Loading

ubbabeck left a comment

ademar111190 Jul 7, 2023

erdemyerebasmaz commented Jul 10, 2023

erdemyerebasmaz commented Jul 11, 2023

Support pasting LNURL #593

Support pasting LNURL #593

Conversation

erdemyerebasmaz commented Jul 5, 2023 • edited Loading

Changelist:

ubbabeck left a comment • edited Loading

Choose a reason for hiding this comment

ubbabeck left a comment

Choose a reason for hiding this comment

ubbabeck commented Jul 6, 2023 • edited Loading

ok300 commented Jul 6, 2023

ubbabeck commented Jul 6, 2023

erdemyerebasmaz commented Jul 6, 2023 • edited Loading

Context for latest changes with 222c64c

Related changes:

ubbabeck left a comment

Choose a reason for hiding this comment

ademar111190 Jul 7, 2023

Choose a reason for hiding this comment

erdemyerebasmaz commented Jul 10, 2023

⚠️ Do not merge until lifecycle problem is addressed. ⚠️

erdemyerebasmaz commented Jul 11, 2023

erdemyerebasmaz commented Jul 5, 2023 •

edited

Loading

ubbabeck left a comment •

edited

Loading

ubbabeck commented Jul 6, 2023 •

edited

Loading

erdemyerebasmaz commented Jul 6, 2023 •

edited

Loading

Context for latest changes with `222c64c`