Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct the payment request info dialog alignment #592

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Correct the payment request info dialog alignment #592

merged 1 commit into from
Jul 6, 2023

Conversation

erdemyerebasmaz
Copy link
Collaborator

@erdemyerebasmaz erdemyerebasmaz commented Jul 5, 2023 •
edited
Loading

This PR addresses

Explanation for the changes are here: #547 (comment)

The UI's code is practically the same between cBreez & Breezmobile, couldn't find the root cause but noticed Column alignments were behaving differently. We have a lot of _addIfNotNull logic, perhaps this difference is due to null safety. Will get back to investigating this later.

For now, I've applied a fix to programmatically allocate the free space around equally around dialog content. There's still a slight difference 🤏 Here's the comparison between cBreez(Dark theme) and Breezmobile(Blue theme) with this fix:

Screen.Recording.2023-07-05.at.19.49.13.mov

@erdemyerebasmaz
Correct the payment request info dialog alignment
dcd2b06 
This is a temporary fix before we find the root cause of Bad 0-amount invoice UI #547
@erdemyerebasmaz erdemyerebasmaz added this to the v0.1.0-alpha milestone Jul 5, 2023
@erdemyerebasmaz erdemyerebasmaz merged commit 234c5cd into main Jul 6, 2023
1 check passed
@erdemyerebasmaz erdemyerebasmaz deleted the payment-request-dialog-alignment branch September 27, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ademar111190 ademar111190 ademar111190 approved these changes

@roeierez roeierez Awaiting requested review from roeierez

@ubbabeck ubbabeck Awaiting requested review from ubbabeck

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.1.0-alpha
Development

Successfully merging this pull request may close these issues.
2 participants
@erdemyerebasmaz @ademar111190