Allow payments below max inbound liquidity when LSP does not support …

…channel openings
breez · Aug 9, 2023 · beba3f7 · beba3f7
1 parent dd6c4ef
commit beba3f7
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 1 deletion.
diff --git a/lib/bloc/account/account_bloc.dart b/lib/bloc/account/account_bloc.dart
@@ -234,6 +234,9 @@ class AccountBloc extends Cubit<AccountState> with HydratedMixin {
           (amount > accState.maxInboundLiquidity && amount <= channelMinimumFee)) {
         throw PaymentBelowSetupFeesError(channelMinimumFee);
       }
+      if (amount > accState.maxInboundLiquidity) {
+        throw PaymentExceedLiquidityError(accState.maxInboundLiquidity);
+      }
       if (amount > accState.maxAllowedToReceive) {
         throw PaymentExceededLimitError(accState.maxAllowedToReceive);
       }

diff --git a/lib/bloc/account/payment_error.dart b/lib/bloc/account/payment_error.dart
@@ -33,3 +33,11 @@ class PaymentBelowSetupFeesError implements Exception {
     this.setupFees,
   );
 }
+
+class PaymentExceedLiquidityError implements Exception {
+  final int limitSat;
+
+  const PaymentExceedLiquidityError(
+    this.limitSat,
+  );
+}
diff --git a/lib/routes/create_invoice/create_invoice_page.dart b/lib/routes/create_invoice/create_invoice_page.dart
@@ -236,7 +236,7 @@ class CreateInvoicePageState extends State<CreateInvoicePage> {
   String? validatePayment(BuildContext context, int amount) {
     final lspInfo = context.read<LSPBloc>().state?.lspInfo;
     int? channelMinimumFee =
-        lspInfo != null ? lspInfo.openingFeeParamsList.values.first.minMsat ~/ 1000 : null;
+        lspInfo != null && lspInfo.openingFeeParamsList.values.isNotEmpty ? lspInfo.openingFeeParamsList.values.first.minMsat ~/ 1000 : null;
 
     return PaymentValidator(
       validatePayment: _validatePayment,

diff --git a/lib/utils/payment_validator.dart b/lib/utils/payment_validator.dart
@@ -50,6 +50,9 @@ class PaymentValidator {
       return texts.invoice_payment_validator_error_payment_below_limit(
         currency.format(e.reserveAmount),
       );
+    } on PaymentExceedLiquidityError catch (e) {
+      // TODO: Add translation
+      return "Insufficient inbound liquidity (${currency.format(e.limitSat)})";
     } on InsufficientLocalBalanceError {
       return texts.invoice_payment_validator_error_insufficient_local_balance;
     } on PaymentBelowSetupFeesError catch (e) {