Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store swap dynamic fees in separate table #355

Merged
merged 7 commits into from
Aug 1, 2023

Conversation

ok300
Copy link
Contributor

@ok300 ok300 commented Jul 26, 2023

No description provided.

Copy link
Member

@roeierez roeierez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

libs/sdk-core/src/persist/swap.rs Outdated Show resolved Hide resolved
@ok300 ok300 requested a review from roeierez July 26, 2023 08:53
@ok300 ok300 mentioned this pull request Jul 28, 2023
Copy link
Contributor

@JssDWt JssDWt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!
One suggestion for the remote sync query.

libs/sdk-core/src/persist/sync.rs Outdated Show resolved Hide resolved
@ok300 ok300 merged commit 22169eb into dynamic_fees Aug 1, 2023
2 checks passed
@ok300 ok300 deleted the ok300-dynamic-fees-swap-fees-table branch August 28, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants