Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: sync all payment updates #1095

Merged
merged 1 commit into from
Oct 7, 2024
Merged

sync: sync all payment updates #1095

merged 1 commit into from
Oct 7, 2024

Commits on Oct 5, 2024

  1. sync: sync all payment updates

    Rather than syncing payments based on the payment time, sync based on
    the created and updated indices in core lightning. This ensures that all
    updates are retrieved, also when a payment is updated after the fact. To
    do this, listsendpays is called, rather than listpays. listsendpays
    contains a filter based on index. Starting off with the last synced
    index, fetch all missing newly created payments and updates. It's
    possible that this particular sync doesn't fetch all payment parts
    associated to a payment. Therefore, the sendpays are cached into a local
    database. When a new sync round is done, all known existing parts are
    fetched from the local database as well, to ensure the resulting sdk
    payments are 'complete', i.e. they're not missing any parts. This should
    fix the issue where for closed channels, payments would be marked
    forever pending.
    JssDWt committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    0b1d841 View commit details
    Browse the repository at this point in the history