Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to VLS 0.12.0 #1084

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Upgrade to VLS 0.12.0 #1084

merged 1 commit into from
Sep 16, 2024

Conversation

dangeross
Copy link
Collaborator

This PR:

  • Removes the signer notification workaround
  • Upgrades Greenlight to latest main
    • VLS - 0.12.0
    • lightning - 0.0.118
    • lightning-invoice - 0.26.0
    • serde_bolt - 0.3.5

roeierez
roeierez approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@roeierez roeierez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Happy to get rid of the custom signer code

JssDWt
JssDWt approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@JssDWt JssDWt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the removal of signer notification workaround does not cause a regression: LGTM!

@dangeross dangeross merged commit d46e40d into main Sep 16, 2024
9 checks passed
@dangeross dangeross deleted the savage-vls-0.12 branch September 16, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roeierez roeierez roeierez approved these changes

@JssDWt JssDWt JssDWt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dangeross @roeierez @JssDWt