Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code fix to address plotting problems in ffm and tsfm objects #82

Merged
merged 4 commits into from
Mar 26, 2022
Merged

Code fix to address plotting problems in ffm and tsfm objects #82

merged 4 commits into from
Mar 26, 2022

Conversation

kecoli
Copy link
Contributor

@kecoli kecoli commented Feb 8, 2022

No description provided.

@JustinMShea JustinMShea merged commit cf1af74 into braverock:master Mar 26, 2022
@JustinMShea
Copy link
Collaborator

@kecoli I am not sure what original or specific issue this attempts to fix, and I believe it had to do with #41.

Your fmCov.R file appears to include legacy data sets StockReturns and Stock.df, that should be deleted during the merge. See issue #58 and then #43. On that note, it would be a good idea to update your local files/branch because it contains a number of outdated files.

I will merge this for now and reference #58 for you or someone else to add test examples with the newer data sets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants