Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for arm64 builds #42

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Conversation

jalaziz
Copy link
Contributor

@jalaziz jalaziz commented Dec 27, 2023

Rather than forcing nitriding to build against the amd64 architecture, support arm64 builds by allowing the ARCH environment variable to override the build architecture.

Also, update the example to automatically choose the build architecture based on the architecture of the machine where the example is built and run.

Rather than forcing nitriding to build against the amd64 architecture,
support arm64 builds by allowing the `ARCH` environment variable to
override the build architecture.

Also, update the example to automatically choose the build architecture
based on the architecture of the machine where the example is built and
run.
example/Makefile Outdated Show resolved Hide resolved
Copy link
Contributor

@rillian rillian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, to me. Thanks!

@rillian rillian merged commit 2bb40ff into brave:master Feb 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants