[Toggle]: Don't use Sass #1215
Open
[Toggle]: Don't use Sass #1215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fallaciousreasoning
requested review from
AlanBreck and
petemill
as code owners
fallaciousreasoning
force-pushed
the
no-sass
branch
from
13b5ae6 to
0b1af4f
Compare
Contributor
|
👋 Thanks for Submitting! This PR is available for preview at the link below. ✅ PR tip preview: https://1215.pr.nala.bravesoftware.com/ - ./tokens/css/variables-android.old.css: 7390 bytes
+ ./tokens/css/variables-android.css: 7390 bytes
---
- ./tokens/css/variables-browser.old.css: 6644 bytes
+ ./tokens/css/variables-browser.css: 6644 bytes
---
- ./tokens/css/variables-ios.old.css: 8180 bytes
+ ./tokens/css/variables-ios.css: 8180 bytes
---
- ./tokens/css/variables-marketing.old.css: 13501 bytes
+ ./tokens/css/variables-marketing.css: 13501 bytes
---
- ./tokens/css/variables-news.old.css: 526 bytes
+ ./tokens/css/variables-news.css: 526 bytes
---
- ./tokens/css/variables-newtab.old.css: 1933 bytes
+ ./tokens/css/variables-newtab.css: 1933 bytes
---
- ./tokens/css/variables-search.old.css: 17733 bytes
+ ./tokens/css/variables-search.css: 17733 bytes
---
- ./tokens/css/variables-web3.old.css: 893 bytes
+ ./tokens/css/variables-web3.css: 893 bytes
---
- ./tokens/css/variables.old.css: 125593 bytes
+ ./tokens/css/variables.css: 125593 bytes
Variables Diff: variables-android.diff--- ./tokens/css/variables-android.old.css 2025-09-17 22:36:48.133481159 +0000
+++ ./tokens/css/variables-android.css 2025-09-17 22:36:11.569345391 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Wed Sep 17 2025 20:34:21 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Sep 17 2025 22:36:11 GMT+0000 (Coordinated Universal Time)
*/
:root {
Variables Diff: variables-browser.diff--- ./tokens/css/variables-browser.old.css 2025-09-17 22:36:48.333481858 +0000
+++ ./tokens/css/variables-browser.css 2025-09-17 22:36:11.557345347 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Wed Sep 17 2025 20:34:21 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Sep 17 2025 22:36:11 GMT+0000 (Coordinated Universal Time)
*/
:root {
Variables Diff: variables-ios.diff--- ./tokens/css/variables-ios.old.css 2025-09-17 22:36:48.503482449 +0000
+++ ./tokens/css/variables-ios.css 2025-09-17 22:36:11.584345446 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Wed Sep 17 2025 20:34:21 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Sep 17 2025 22:36:11 GMT+0000 (Coordinated Universal Time)
*/
:root {
Variables Diff: variables-marketing.diff--- ./tokens/css/variables-marketing.old.css 2025-09-17 22:36:48.659482992 +0000
+++ ./tokens/css/variables-marketing.css 2025-09-17 22:36:11.604345520 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Wed Sep 17 2025 20:34:21 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Sep 17 2025 22:36:11 GMT+0000 (Coordinated Universal Time)
*/
:root {
Variables Diff: variables-news.diff--- ./tokens/css/variables-news.old.css 2025-09-17 22:36:48.825483572 +0000
+++ ./tokens/css/variables-news.css 2025-09-17 22:36:11.650345688 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Wed Sep 17 2025 20:34:21 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Sep 17 2025 22:36:11 GMT+0000 (Coordinated Universal Time)
*/
:root {
Variables Diff: variables-newtab.diff--- ./tokens/css/variables-newtab.old.css 2025-09-17 22:36:49.004484195 +0000
+++ ./tokens/css/variables-newtab.css 2025-09-17 22:36:11.660345725 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Wed Sep 17 2025 20:34:21 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Sep 17 2025 22:36:11 GMT+0000 (Coordinated Universal Time)
*/
:root {
Variables Diff: variables-search.diff--- ./tokens/css/variables-search.old.css 2025-09-17 22:36:49.172484783 +0000
+++ ./tokens/css/variables-search.css 2025-09-17 22:36:11.634345630 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Wed Sep 17 2025 20:34:21 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Sep 17 2025 22:36:11 GMT+0000 (Coordinated Universal Time)
*/
:root {
Variables Diff: variables-web3.diff--- ./tokens/css/variables-web3.old.css 2025-09-17 22:36:49.266485112 +0000
+++ ./tokens/css/variables-web3.css 2025-09-17 22:36:11.665345744 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Wed Sep 17 2025 20:34:21 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Sep 17 2025 22:36:11 GMT+0000 (Coordinated Universal Time)
*/
@media (prefers-color-scheme: light) {
Variables Diff: variables.diff--- ./tokens/css/variables.old.css 2025-09-17 22:36:49.503485938 +0000
+++ ./tokens/css/variables.css 2025-09-17 22:36:11.424344859 +0000
@@ -1,6 +1,6 @@
/**
* Do not edit directly
- * Generated on Wed Sep 17 2025 20:34:21 GMT+0000 (Coordinated Universal Time)
+ * Generated on Wed Sep 17 2025 22:36:11 GMT+0000 (Coordinated Universal Time)
*/
:root {
|
| -webkit-tap-highlight-color: transparent; | ||
| } | ||
| @media (prefers-reduced-motion) { |
Collaborator
Author
There was a problem hiding this comment.
note: modern CSS doesn't support nesting media queries so we have to unnest them
Member
|
For example of how toggle broken, see brave/brave-browser#49379 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent bump to Sass broke our
themeplugin. Fortunately, modern CSS has most of the features we'd use from Sass so converting over to plain CSS fixes things!