Add Brave-P3A-Version header support, ignore requests with older client revision
#92
Conversation
DJAndries
force-pushed
the
client-rev-filter
branch
from
62a77bd to
6f7e18e
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| channel, | ||
| value | ||
| .parse::<usize>() | ||
| .expect("minimum channel revision should be non-negative integer"), |
There was a problem hiding this comment.
reported by reviewdog 🐶
[semgrep] expect or unwrap called in function returning a Result
Source: https://semgrep.dev/r/trailofbits.rs.panic-in-function-returning-result.panic-in-function-returning-result
Cc @thypon @bcaller
There was a problem hiding this comment.
This use is ok. Input is controlled by an environment variable in the launch environment and so under the control of the deployer; outside input cannot trigger a panic here. The check is in startup code, so failing quickly on mis-configuration is appropriate.
| channel, | ||
| value | ||
| .parse::<usize>() | ||
| .expect("minimum channel revision should be non-negative integer"), |
There was a problem hiding this comment.
This use is ok. Input is controlled by an environment variable in the launch environment and so under the control of the deployer; outside input cannot trigger a panic here. The check is in startup code, so failing quickly on mis-configuration is appropriate.
| v.to_str() | ||
| .unwrap_or_default() | ||
| .parse::<usize>() | ||
| .unwrap_or_default() |
There was a problem hiding this comment.
Just to confirm, this means requests without the revision header will be treated as if they sent Brave-Constellation-Rev: 0 so we're not necessarily excluding all currently-deployed clients?
DJAndries
force-pushed
the
client-rev-filter
branch
from
6f7e18e to
45a31a4
Compare
DJAndries
changed the title
Brave-Constellation-Rev header support, ignore requests with older client revisionBrave-P3A-Revision header support, ignore requests with older client revision
DJAndries
force-pushed
the
client-rev-filter
branch
from
45a31a4 to
2b62b0a
Compare
DJAndries
force-pushed
the
client-rev-filter
branch
from
2b62b0a to
cc1cf8f
Compare
DJAndries
changed the title
Brave-P3A-Revision header support, ignore requests with older client revisionBrave-P3A-Version header support, ignore requests with older client revision
No description provided.