Handle measurement mismatch errors, add debug logging #91
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| }) | ||
| match pms.iter().find(|v| v.is_ok()) { | ||
| None => { | ||
| let first_error = pms.iter().next().unwrap().clone().unwrap_err(); |
There was a problem hiding this comment.
reported by reviewdog 🐶
[semgrep] expect or unwrap called in function returning a Result
Source: https://semgrep.dev/r/trailofbits.rs.panic-in-function-returning-result.panic-in-function-returning-result
Cc @thypon @bcaller
There was a problem hiding this comment.
This assumes there's at least one element in pms. Something like
let first_error = pms.first().unwrap_or(&...).| Err(AppSTARError::Recovery(first_error)) | ||
| } | ||
| Some(measurement) => Ok(MsgRecoveryInfo { | ||
| measurement: get_measurement_contents(measurement.as_ref().unwrap())?, |
There was a problem hiding this comment.
reported by reviewdog 🐶
[semgrep] expect or unwrap called in function returning a Result
Source: https://semgrep.dev/r/trailofbits.rs.panic-in-function-returning-result.panic-in-function-returning-result
Cc @thypon @bcaller
There was a problem hiding this comment.
Unwrap here isn't new, but this could be measurement.as_ref().map_err(|e| e.to_owned())? or similar?
To debug issues with the express cron