-
Notifications
You must be signed in to change notification settings - Fork 899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ai chat): Delete Conversation Confirmation Dialog #27149
feat(ai chat): Delete Conversation Confirmation Dialog #27149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks great! I'd prefer if we didn't need to put this state into the context, but if there's a reason we need it there then this should be fine.
components/ai_chat/resources/page/components/conversations_list/index.tsx
Outdated
Show resolved
Hide resolved
components/ai_chat/resources/page/components/delete_conversation_modal/index.tsx
Outdated
Show resolved
Hide resolved
components/ai_chat/resources/page/components/delete_conversation_modal/index.tsx
Show resolved
Hide resolved
A Storybook has been deployed to preview UI for the latest push |
2a7f411
to
bcd2311
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Storybook needs a small fix, but the strings look good
caf654e
to
8b040a9
Compare
components/ai_chat/resources/page/components/delete_conversation_modal/index.tsx
Outdated
Show resolved
Hide resolved
8b040a9
to
e0c4e31
Compare
e0c4e31
to
5d708cf
Compare
Released in v1.76.29 |
Description
Will now prompt the user with a
Confirmation
dialog when attempting to delete a conversation.Resolves brave/brave-browser#42969
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Leo
More Menu
for a chat and then clickDelete conversation
Confirmation Dialog
to eitherCancel
orDelete
the conversation.Screen.Recording.8.mov