Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ai chat): Delete Conversation Confirmation Dialog #27149

Merged

Conversation

Douglashdaniel
Copy link
Contributor

Description

Will now prompt the user with a Confirmation dialog when attempting to delete a conversation.

Resolves brave/brave-browser#42969

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Start multiple conversations with Leo
  2. Click the More Menu for a chat and then click Delete conversation
  3. You should be prompted with a Confirmation Dialog to either Cancel or Delete the conversation.
Screen.Recording.8.mov

@Douglashdaniel Douglashdaniel self-assigned this Jan 8, 2025
@Douglashdaniel Douglashdaniel requested a review from a team as a code owner January 8, 2025 01:53
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Jan 8, 2025
Copy link
Contributor

@fallaciousreasoning fallaciousreasoning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks great! I'd prefer if we didn't need to put this state into the context, but if there's a reason we need it there then this should be fine.

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel force-pushed the feat-ai-chat-delete-conversation-confirmation-dialog branch from 2a7f411 to bcd2311 Compare January 8, 2025 18:58
Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Storybook needs a small fix, but the strings look good

@Douglashdaniel Douglashdaniel force-pushed the feat-ai-chat-delete-conversation-confirmation-dialog branch 2 times, most recently from caf654e to 8b040a9 Compare January 15, 2025 19:29
@Douglashdaniel Douglashdaniel force-pushed the feat-ai-chat-delete-conversation-confirmation-dialog branch from 8b040a9 to e0c4e31 Compare January 21, 2025 18:45
@Douglashdaniel Douglashdaniel force-pushed the feat-ai-chat-delete-conversation-confirmation-dialog branch from e0c4e31 to 5d708cf Compare January 21, 2025 18:47
@Douglashdaniel Douglashdaniel merged commit 54ae237 into master Jan 21, 2025
18 checks passed
@Douglashdaniel Douglashdaniel deleted the feat-ai-chat-delete-conversation-confirmation-dialog branch January 21, 2025 21:41
@github-actions github-actions bot added this to the 1.76.x - Nightly milestone Jan 21, 2025
@brave-builds
Copy link
Collaborator

Released in v1.76.29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Leo] Deleting a conversation must have a confirmation dialog
4 participants