Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spanify] span size/offset to conform to size_t #26822

Merged
merged 1 commit into from
Dec 3, 2024

Commits on Dec 3, 2024

  1. [Spanify] span size/offset to conform to size_t

    There's some tightening around values passed into span, with
    `StrictNumeric<size_t>` being enforced. This is mostly unimportant when
    dealing with compile-time values, as they can be validated on the spot,
    however it does affect several places where the value is unknown at
    runtime, and a signed value was being used.
    
    Chromium changes:
    https://chromium.googlesource.com/chromium/src/+/4937ad9ae64d9d3f05d13c9d041769432a12281b
    
    ```
    commit 4937ad9ae64d9d3f05d13c9d041769432a12281b
    Author: Peter Kasting <[email protected]>
    Date:   Tue Nov 26 22:58:16 2024 +0000
    
        Use StrictNumeric<size_t> for more span methods.
    
        Changes subspan(), split_at(), at(), and get_at() to match pre-existing
        usage in constructors, first(), last(), etc.
    
        Bug: 364987728
    ```
    
    Resolves brave/brave-browser#42627
    cdesouza-chromium committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    817424f View commit details
    Browse the repository at this point in the history