-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't clear first party storage area if browser is launched in incognito mode from command line #24543
Closed
Ilie-Lesan
wants to merge
3,050
commits into
brave:master
from
Ilie-Lesan:ignore-clean-cookies-at-startup-for-command-line-incognito-mode
Closed
Don't clear first party storage area if browser is launched in incognito mode from command line #24543
Changes from 1 commit
Commits
Show all changes
3050 commits
Select commit
Hold shift + click to select a range
35a0d15
[iOS] - Update Guardian Connect & Add Smart Proxy Setting & Kill Swit…
Brandon-T e3b611f
Resolve QSE google search query
deeppandya 1d1f125
sets default shortcut for screenshot via sharing hub (#26885)
jonathansampson 1e78602
[ads] const std::string_view code health
tmancey 37403be
[ads] base::MakeFixedFlatSet code health
tmancey 25da4b8
[ads] std::optional code health
tmancey ced5821
[ads] IWYU code health
tmancey 0b571c1
[ads] Move constructor code health
tmancey 5d55612
[ads] Vertical whitespace code health
tmancey a6736dc
[Web UI]: Convert Bookmarks to new overrides (#26880)
fallaciousreasoning ffcf9ee
1.75.78
brave-builds 846d68c
fix(privacy): Secure access to window origin on iOS (#26841)
StephenHeaps 517ccc1
Fixed empty space is added in guest window's app menu
simonhong 1468c1c
1.75.79
brave-builds 21abe98
[Web UI]: Convert extensions to new overrides (#26881)
fallaciousreasoning d6c5d0a
Bump path-to-regexp and express
dependabot[bot] 675d171
Disable cosmetic filtering on Speedreader pages (#25692)
boocmp 178380f
Introduced enum type for vpn's manage url
simonhong a796f27
Fixed build failure on linux due to not defined vpn method in linux
simonhong f88a11e
1.75.80
brave-builds 1045fc3
Workaround for crbug.com/378381144 (#26899)
atuchin-m e366381
Removed unnecessary separator from more tools menu
simonhong d136127
[DanglingPtr] Enable the dector for iOS builds (#26856)
cdesouza-chromium af61861
Reverted to using github.event.pull_request.base.sha as the target sh…
wknapik 4ca60d0
[Rewards 3.0] Add small UI improvements
zenparsing c01e357
[Rewards 3.0] Retry Ads service if Ads service is restarting
zenparsing d394822
Upate QSE edit url behaviour
deeppandya 67dff3a
1.75.81
brave-builds 337209f
[iOS] - Make Playlist WebCompat only apply to Playlist WebViews and n…
Brandon-T 37fb8d9
fix(wallet): Dismiss Transactions Partner Modal on First Click
Douglashdaniel b4c87a0
Fix wallet asset images not fetched from nala design system. (#26909)
StephenHeaps 747e24d
Fix blank privacy settings page
emerick 3a07c17
Farbling per site improvements (#26827)
goodov 23733e6
Override SyncPrefs::SetPasswordSyncAllowed to keep password_sync_allo…
AlexeyBarabash 8870df0
Unit test to ensure SyncPrefs::SetPasswordSyncAllowed is no-op
AlexeyBarabash 0e55025
Fixed gn_check missing deps error
AlexeyBarabash 67ddf4d
1.75.82
brave-builds 632744e
1.75.83
brave-builds 1b576f3
Changed ParameterName presubmit rule severity to error (#26794)
AlexeyBarabash cc06a78
Pin dependency @types/bs58 to 4.0.4 (#26652)
renovate[bot] f73c903
Removes person/people -> profile string replacements.
mkarolin e9ff68f
Adds extra check on ViewProvider class methods in bytecode tests on A…
SergeyZhukovsky aa9a0b0
[DanglingPtr] Enable dangling detection on Windows (#26904)
cdesouza-chromium 6841947
[ads] const code health
tmancey fce835d
Fix crash when clicking profile button in guest window
emerick 14eed15
1.75.84
brave-builds f79d8e5
1.75.85
brave-builds fba1917
Adjusted location bar right edge padding
simonhong 6577d2e
keep an AI Chat conversation alive if it has chat messages and its as…
petemill 9095f67
Keep conversations in memory if content is alive even when AIChatHist…
petemill 223e1aa
fix DanglingPtr in unit test
petemill 73b6f22
Roll perf profiles update (update-perf-profile-2024-12-08-16-16) (#26…
brave-builds 7ea0584
Removed failed assertions for SUBRESOURCE_FILTER and CSD_ALLOWLIST re…
AlexeyBarabash fb7792f
Hide arrow button in Safe Browsing section of brave://settings/security
emerick c4907d4
1.75.86
brave-builds 459bf33
Improve contrast on active tab for dark mode (#26928)
aguscruiz 64f1067
1.75.87
brave-builds c75cbce
Fix News dangling ptr crash
DJAndries 6ae345a
Add 3-second timer for HTTPS upgrades before falling back to HTTP on …
StephenHeaps 821f639
fix(wallet): Allow Creating Wallet on Buy Screen (#26850)
Douglashdaniel da1e9f5
Remove obsolete ProfileMenuViewBase patch and override
emerick 0cfde8b
don't override critical codeowner entries (#26944)
bridiver ef737ca
Fixes a crash on Quick Search on Android when TemplateUrlService is n…
SergeyZhukovsky 847322a
1.75.88
brave-builds 50a6e2e
[Webpack]: Remove unused url-loader
fallaciousreasoning c749d8e
[Overrides]: Move interface registration to brave_content_renderer_cl…
fallaciousreasoning 45369d9
1.75.89
brave-builds f7f6769
[iOS] Add constellation support for NTT p3a metrics
kylehickinson 28b9585
[ads] Remove ShouldLaunchBraveAdsAsInProcessService feature
aseren 8df49c9
1.75.90
brave-builds 71d4eaa
AI Chat: android should use tab-default conversation in the popup
petemill b108641
[iOS] - Update text for playlist quick-action button (#26930)
Brandon-T e71db2c
Partial l10n for VPN widget.
mkarolin 9c63fe8
Bump nanoid from 3.3.7 to 3.3.8 (#26948)
dependabot[bot] 8056c3f
[ads] Optimize database queries serialization/deserialization overhead
aseren 12dbe76
[ads] Change Brave Ads tests to use async DB calls.
aseren 7146285
[ads] Make brave_ads::Database class internal to ads.
aseren c6be4e6
[ads] Disable NotificationAdPopupBrowserTest
aseren 951d084
[iOS] Remove Third-Party mentions in VPN. Change AppStore to App Stor…
Brandon-T e0e5712
[Rewards 3.0] Validate explore card links and thumbnails
zenparsing 5d9cf7b
Upgrade News direct feed requests to HTTPS when possible
DJAndries 316e018
Call News fetcher delegate on UI thread
DJAndries 2bc3367
Use `base::WeakPtr` for `DirectFeedFetcher::Delegate` call
DJAndries 8f1c654
1.75.91
brave-builds abfdfae
Don't show toast notifications when copying links or images
emerick 604edd9
[AI Chat] Introduces support for host-specific distiller scripts (#25…
jonathansampson cecf928
1.75.92
brave-builds dd15dec
[iOS] - Inject VPN subscription info on script message (#26969)
Brandon-T 7e00b8d
Do not allow configuring tabs with javascript no matter what (#26932)
Brandon-T 433d4b4
[AI Chat]: Update Android UI to open AI Chat in a tab (#26823)
fallaciousreasoning 36b4987
Upgrade from Chromium 132.0.6834.33 to Chromium 132.0.6834.46 (#26985)
emerick 8f6a56e
Brave Account `brave://settings` UI.
szilardszaloki 8fc4471
Removes the "Account name" input field.
szilardszaloki fa938a3
AI Chat becomes a trusted WebUI with an UntrustedWebUI frame for LLM-…
petemill 5f5193b
1.75.93
brave-builds a4fe90f
1.75.94
brave-builds 899a5a6
modify default screenshot shortcut to use the accelerator key (#26993)
jonathansampson dc561bf
1.75.95
brave-builds 390a23e
Disable v2 ext on toggle turning off. Added the `Remove` button for d…
boocmp 7cceb83
[iOS] - Get rid of Window Render Script (#26992)
Brandon-T 70aa9b3
[iOS] - Fix race condition for private browsing only mode (#26931)
Brandon-T b8e4c39
fix(wallet): Post Confirmation Transfer Value
Douglashdaniel 8fb9484
style(wallet): Edit Gas Slider Track
Douglashdaniel 870c490
fix(wallet): Prevent Double Account Creation on Buy Screen
Douglashdaniel d6f426f
fix(wallet): Backup Wallet Progress Indicator
Douglashdaniel 200a52e
fix(wallet): Speedup Transaction
Douglashdaniel 4aeae6a
[NTP Search]: Change color to browser theme
fallaciousreasoning 446cb40
1.75.96
brave-builds f0395ed
[iOS] Add local search to Playlist
kylehickinson 1e9f640
Update leo dependency
petemill d2b154b
[iOS] - Fix brave://flags crash (#26986)
Brandon-T 91d4cf5
feature(privacy): Add debug view to iOS to display blocked requests p…
StephenHeaps f6cece3
[iOS] Add new browser menu UI (#26805)
kylehickinson 36bddcf
1.75.97
brave-builds 5b21110
Remove toast notification for adding article to reading list
emerick 718fa7a
[Rewards 3.0] Add creator ID parameter to Rewards page
zenparsing c5c8329
[AI Chat]: Make it possible to Open AI Chat when history is disabled …
fallaciousreasoning a10066a
1.75.98
brave-builds 80124af
[ads] Add search result ad clicked InfoBar
aseren f3acda4
Implement height-based animation for Toast on iOS
aseren 604f4c0
[iOS] Fix request desktop site action in new menu UI
kylehickinson f36b473
Upgrade direct feed redirect requests to HTTPS, respect strict upgrad…
DJAndries 4f34de3
Add News Direct feed redirect test
DJAndries 74e6911
Added Custom Scriptlet section in the settings page. (#25999)
boocmp fbad66b
[AI Chat] allow clipboard-write in conversation entries frame
petemill 55d2551
1.75.99
brave-builds f2c1a5f
Add shardtree crate (#26966)
cypt4 1f0d310
[Android] Fix for default action on opening link
samartnik c11f0e7
1.75.100
brave-builds 52a0cd3
[iOS] - Revert SkusScript MethodIDs (#27010)
Brandon-T 3f57cb6
Update nala dependency
petemill a9f9ba1
[iOS] - Add New-Line to localizable.strings (#27015)
Brandon-T 695acda
[ZCash ] Implement shard tree and shard storage (#26477)
cypt4 9aab46c
Fixes missing Russian l10n for two strings. (#26981)
mkarolin e342038
enable AIChatHistory feature for android and desktop
petemill 7a19c31
AI Chat storage notice is dismissed after first prompt sending or clo…
petemill cc27904
Fix `BraveStatsUpdater` instantiation
DJAndries 98653e6
AssistantResponse uses key for events
petemill 1834ac3
AI Chat conversations list item menu and edit improvements
petemill 669bd2d
Don't crash when editing the title of a conversation not in-memory
petemill 5c3b3d2
Revert "Disable CustomBackgroundFileManagerBrowserTest.SaveImageMulti…
mihaiplesa 7a1a9bf
Replaced tab group icon in bookmarks bar
simonhong 9092f0e
1.75.101
brave-builds d9ef39a
Added separator to inactive split view tab
simonhong bc3ceba
Applied latest split view bg color to priv/tor window
simonhong aedf3e6
Updated active/hover bg color of inactive tab in split view
simonhong 68e7e53
Temporary disabled flacky test. (#27021)
boocmp 473dfa3
Using Nala color provider for Speedreader. (#27022)
boocmp 79b1db6
Await for element in list. (#27026)
boocmp 8faefd2
1.75.102
brave-builds ef57f0d
Replaced lint-suppressions.xml.patch with python chromium_src overrid…
AlexeyBarabash 8701b30
style(wallet): Fix Cut Off Brave Logo
Douglashdaniel d251078
1.75.103
brave-builds 06978b2
feat(wallet): Cancel & Speed Up Tx in Tx Status Screen (#26947)
nuo-xu 797d374
Remove workaround for crbug.com/6013664 (#27028)
atuchin-m eef895f
(Wallet) Fix crash KeystoreHelper class (#27027)
simoarpe eba9642
Use precomputed `caller` in the file save dialog title. (#26953)
goodov 9a79330
Fix YouTube creator detection for search navigations
zenparsing fd859e2
Allows to use a microphone for Brave Talk in the background on Android
SergeyZhukovsky b709d02
Element Picker on Android (#26725)
vadimstruts a450ebb
1.75.104
brave-builds 4ad3ba7
[AI Chat] disable history feature enabled by default on Android
petemill 5d628da
[AI Chat] WebManifest for PWA install
petemill 131a842
Use color favicon for AI Chat
petemill 238e21c
AI Chat gets conversation title as Tab title and better PWA name
petemill 37f9c31
1.75.105
brave-builds d3f2a3f
fix(ios): update tab bar visibility after ChromeWebViewController is …
nuo-xu ade4fdc
1.75.106
brave-builds 5400766
fix(vpn): Centre alignment on text in server selection pop-up (#27034)
nuo-xu 140a9f6
Fix enable_speedreader buildflag to be !is_ios instead of true
emerick 7223262
[ads] AdsServiceImpl code health
aseren 7ee1b03
Fixed wrong gap between tab and toolbar
simonhong 024cebd
1.75.107
brave-builds 8c298dc
Make sure sync URL is set to sane value if .env is not configured. (#…
goodov f9873da
1.75.108
brave-builds 73b3497
1.75.109
brave-builds f16d1fe
Add feature flag for new onboarding
deeppandya 4db9ab0
Removing dayzero changes and update onboarding with new flag
deeppandya fb5c43e
Add android exception
deeppandya f14c354
Remove lottie animation
deeppandya 469cd53
Add static image as we removed the animation
deeppandya 363b349
Add dark image res
deeppandya 7d4dd07
[AI Chat]: Android history setting (#26988)
fallaciousreasoning 0c13841
codeowner - new WebUI should use RegisterChromeWebUIConfigs (#27057)
bridiver 483d888
[Rewards 3.0] Provide a fallback thumbnail for explore cards
zenparsing da70331
1.75.110
brave-builds bc30921
Update Leo help links (#27051)
diracdeltas 7f1f0e7
1.75.111
brave-builds 48f845d
Fix dangling pointer crash in ZCashRpc (#27062)
cypt4 d3847dd
1.75.112
brave-builds 9bb15fc
(Wallet) Check if asset array contains null values (#27067)
simoarpe 5d1c007
1.75.113
brave-builds b27c32c
update renovate.json
mihaiplesa 4f9fa6b
fix(ios): Fix user sometimes cannot scroll the tab bar (#27061)
nuo-xu ed79055
fix(wallet): Transactions Partner Modal Bugs
Douglashdaniel 1aa8077
add brave-ai-chat-page-context flag (#27065)
thypon 88e4a04
1.75.114
brave-builds 808c33e
Upgrade from Chromium 132.0.6834.46 to Chromium 132.0.6834.57 (#27073)
emerick 357c803
1.75.115
brave-builds 6144164
Prevent external favicons fetch on password manager page. (#27066)
goodov e05c752
[iOS] - Fix alert continuation leak when WebKit automatically cancels…
Brandon-T 45af846
separate alerting origin from download origin (#27049)
diracdeltas 508a284
1.75.116
brave-builds bc0bac2
fix(vpn): fix sometimes server region list is not populated after rel…
nuo-xu 07d4ea8
Add metric configuration and alternative metric attributes
DJAndries 2842027
Address P3A metric config feedback
DJAndries 1837a63
Adds preferences and methods to delete Leo conversations on Android (…
SergeyZhukovsky c2ec032
1.75.117
brave-builds 19ba1a0
Roll perf profiles update (update-perf-profile-2024-12-22-16-16) (#27…
brave-builds 86463e0
1.75.118
brave-builds bca3254
1.75.119
brave-builds 052190f
[iOS] - Fix URL-Bar logic handling about:blank (#27080)
Brandon-T 5600f45
fix(vpn): display country name for Singapore server selection (#27088)
nuo-xu 480fa7f
fix(wallet): fix wallet currency is not updating correctly (#27070)
nuo-xu f3403cb
1.75.120
brave-builds 47bdfe6
Do not require screenlock on ChromeOS for passwords sync (#27056)
AlexeyBarabash 22fd74c
1.75.121
brave-builds 400b805
[ZCash] Fetch consensus branch id from the backend (#27089)
cypt4 f85519c
1.75.122
brave-builds 82f849f
1.75.123
brave-builds 291cbfe
1.75.124
brave-builds 7464671
1.75.125
brave-builds 719b8b5
1.75.126
brave-builds fd46063
1.75.127
brave-builds bfc06c7
Improve android rebooting in perf tests (#27093)
atuchin-m 165e0e6
1.75.128
brave-builds 9bc156a
Remove cross promo dialog
deeppandya 6b0e974
1.75.129
brave-builds 4c299aa
1.75.130
brave-builds 42931e4
feat(wallet): add Base to preloaded EVM networks (#27013)
onyb 8ed9a06
1.75.131
brave-builds aaa5b5d
Add proprietary_codecs:true to perf chromium build (#27096)
atuchin-m d280ebd
1.75.132
brave-builds beea032
1.75.133
brave-builds 37563e4
Roll perf profiles update (update-perf-profile-2024-12-29-16-16) (#27…
brave-builds 9570066
fix(wallet): Remove Bridge To Aurora Button
Douglashdaniel db0adeb
1.75.134
brave-builds 0e04dda
Adding Crowdin integration to l10n scripts.
mkarolin 941c4d2
Code Review fixes.
mkarolin e02e7a5
Added timeouts to requests.get calls.
mkarolin 852c505
1.75.135
brave-builds 65ae106
Wallet openssl ed25519 (#26770)
supermassive 630f624
Fix UNSAFE_TODO for wallet [part 4 of N] (#26854)
supermassive 211a36a
1.75.136
brave-builds 7fe013c
feat(wallet): Add Activity to Portfolio Desktop View
Douglashdaniel a795de9
1.75.137
brave-builds b515b6c
1.75.138
brave-builds b5c5299
1.75.139
brave-builds a7a2cc9
1.75.140
brave-builds 52ad91c
Fix ephemeral storage service unit test when the profile doesn't hav…
Ilie-Lesan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe the better approach here is to detect if any "normal" profile windows are opened or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion, I will try to follow it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Please have a look