-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seperated and Added to the Linux and Andriod Install Pages #38942
base: master
Are you sure you want to change the base?
Conversation
Splitting the instructions for Android and Linux is reasonable, but so far instructions for all platforms are on the wiki, not in the repo. I'd rather keep it consistent. The advantage of the wiki is that changes are quick and easy compared to opening a brave-core PR. But if we go for repo instead, why just two platforms? If we decide to switch to the repo, we should replace the content of the relevant wiki pages with links to the markdown files in the repo. If we decide to go with the wiki, I'm not sure if there's a way to have external contributions there. @mihaiplesa @bsclifton - wdyt? Other than the above:
Given that these are instructions for developers, I think this should be reviewed by someone on the dev team. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Android.md
@@ -0,0 +1,57 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
|
||
Alternatively, you can use Yarn. Follow the [Yarn install docs](https://yarnpkg.com/getting-started/install) to install Yarn and a compatible version of Node.js. After installing Yarn, run `yarn import` to create a `yarn.lock` file from `package-lock.json`. | ||
|
||
## Additonal installs for different Linux distributions: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## Additonal installs for different Linux distributions: | |
## Additional installs for different Linux distributions: |
Resolves #38572
Submitter Checklist:
I separated the Linux and Android install pages as to provide more clarity for developers targeting these operating systems. I also added some additional information for more Linux distributions and a short guide on setting up the Android emulator. This is addressing the open issue: #38572.
Currently I have added the two files in the home directory as markdown files, as I don't have permission to edit the Wiki directly.