-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Spanify] span
size/offset to conform to size_t
#26822
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goodov
approved these changes
Dec 3, 2024
boocmp
approved these changes
Dec 3, 2024
supermassive
reviewed
Dec 3, 2024
supermassive
reviewed
Dec 3, 2024
supermassive
reviewed
Dec 3, 2024
supermassive
reviewed
Dec 3, 2024
supermassive
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wallet core lgtm
cdesouza-chromium
force-pushed
the
use-span-with-sizet
branch
from
December 3, 2024 12:42
c438976
to
b81476b
Compare
There's some tightening around values passed into span, with `StrictNumeric<size_t>` being enforced. This is mostly unimportant when dealing with compile-time values, as they can be validated on the spot, however it does affect several places where the value is unknown at runtime, and a signed value was being used. Chromium changes: https://chromium.googlesource.com/chromium/src/+/4937ad9ae64d9d3f05d13c9d041769432a12281b ``` commit 4937ad9ae64d9d3f05d13c9d041769432a12281b Author: Peter Kasting <[email protected]> Date: Tue Nov 26 22:58:16 2024 +0000 Use StrictNumeric<size_t> for more span methods. Changes subspan(), split_at(), at(), and get_at() to match pre-existing usage in constructors, first(), last(), etc. Bug: 364987728 ``` Resolves brave/brave-browser#42627
cdesouza-chromium
force-pushed
the
use-span-with-sizet
branch
from
December 3, 2024 14:45
b81476b
to
817424f
Compare
Released in v1.75.71 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's some tightening around values passed into span, with
StrictNumeric<size_t>
being enforced. This is mostly unimportant when dealing with compile-time values, as they can be validated on the spot, however it does affect several places where the value is only known at runtime, and a signed value was being used.Chromium changes:
https://chromium.googlesource.com/chromium/src/+/4937ad9ae64d9d3f05d13c9d041769432a12281b
Resolves brave/brave-browser#42627
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: