Skip to content

feat(logger): add OpenTelemetry-compatible log emission - #759

Open
Abhijeet Prasad (AbhiPrasad) wants to merge 1 commit into
mainfrom
abhi-logs
Open

feat(logger): add OpenTelemetry-compatible log emission#759
Abhijeet Prasad (AbhiPrasad) wants to merge 1 commit into
mainfrom
abhi-logs

Conversation

@AbhiPrasad

@AbhiPrasad Abhijeet Prasad (AbhiPrasad) commented Sep 10, 2026

Copy link
Copy Markdown
Member

resolves https://linear.app/braintrustdata/issue/SDK-341/add-logging-api-to-python-sdk

Summary

Add first-class log emission to the project logger so applications can create independent type="log" rows without constructing spans manually.

  • Add Logger.emit_log(body, level, metadata).
  • Add trace(), debug(), info(), warn(), error(), and fatal() convenience methods.
  • Map the six base OpenTelemetry severities to context.otel.log.
  • Add SpanTypeAttribute.LOG.
  • Populate error from string bodies emitted at error or fatal severity.

Usage

logger.error(
    "Payment failed",
    metadata={"payment_id": "pay_123"},
)

logger.emit_log(
    body="Retrying payment",
    level="info",
    metadata={"attempt": 2},
)

Trace correlation

Each log has a unique row ID and span ID unless it is correlated with an active span. A logger seeds one baseline trace ID when it is created, so consecutive unscoped logs from that logger remain grouped without grouping logs from separate logger instances.

helper -> emit_log -> type="log" row
                     |-- active span
                     |     trace_id = active trace_id
                     |     span_id  = active span_id
                     |
                     `-- no active span
                           trace_id = logger baseline trace_id
                           span_id  = newly generated span_id

This works with both native Braintrust spans and active OpenTelemetry spans through the existing context manager abstraction.

Testing

  • nox -s test_core -- -k 'emit_log or log_level_helpers'
  • nox -s test_types
  • OTel active-span correlation test with the otel extra installed
  • make lint

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-10T15:29:04.237312Z 29dcbc0 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Add `Logger.emit_log()` so applications can emit independent `type="log"`
rows without constructing spans manually. Correlate rows with the active
Braintrust or OpenTelemetry context when available.

Seed each logger with a baseline trace ID for unscoped logs. This keeps
consecutive logs from one logger together while preserving unique row and span
IDs, and avoids grouping logs emitted by separate logger instances.

Map the six base OpenTelemetry severities into `context.otel.log` and add
`trace()`, `debug()`, `info()`, `warn()`, `error()`, and `fatal()` helpers.

    logger.error("Payment failed", metadata={"payment_id": "pay_123"})

    helper -> emit_log -> `type="log"` row
                         |-- active span: reuse trace/span IDs
                         `-- no span: reuse logger trace, generate span ID
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant