Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont clear and echo before running test commands with vim-test #219

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

westonganger
Copy link

What

Dont clear and echo before running test commands with vim-test such as \rf

Before:
\rf
clear; echo "bundle exec rspec spec/foo/bar_spec.rb:152"; bundle exec rspec spec/foo/bar_spec:152

After:
\rf
bundle exec rspec spec/foo/bar_spec:152

Why

  • Clearing the screen is not very helpful, many times I want to see the failures that had occured in runs prior and other details.
  • The echo statement is actually confusing because sometimes you may start out with an \rf which would output
    • echo "bundle exec rspec spec/foo/bar_spec.rb:152"; bundle exec rspec spec/foo/bar_spec.rb:152"
    • Many times I want to just re-run the spec file with a different line number, you may just manually re-run the last command and change the last line 152 to something else and then your pair will be like "huh which spec are you running?" this is because of the clear and echo statement which still claims to be line 152

Checklist

  • Send RFC email to Braintree developers if change may be impactful. Please include a link to this PR so that discussion about the pros and cons of the change remains linked to the proposed changes. Recent examples include: addition of linter and completer, no longer removing end-of-line whitespace on save, changing to fzf for file lookup.

Copy link
Contributor

@jcoleman jcoleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve found this bothersome for a long time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants